Added a configuration object for the DbfRecord class #141
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is possible to run into issues where a value in a dbf file is has a type of
Float
, but is larger than afloat
in C#.This would cause precision issues when the value is passed into the
float.TryParse
method.See the below example:
It's worth noting that calling
ToString
on the float with no parameters would round to the nearest hundredth and coincidentally show the value as what it is supposed to be.In order to mitigate this, a configuration class was created that can be passed into the
DbfRecord
class. This configuration currently contains one property (ReadFloatsAsDecimals
) that will tell theCreateDbfValue
method to use theDbfValueDecimal
class for floats instead of theDbfValueFloat
class.The configuration that gets provided is an optional parameter on the
DbfRecord
class and provides a default configuration that matches the current expected behavior.