Added outdated + update commands #135
Conversation
| @@ -130,7 +130,7 @@ public class Mint { | |||
| return versionsByPackage | |||
| } | |||
|
|
|||
| func resolvePackage(_ package: PackageReference) throws { | |||
| func resolvePackage(_ package: PackageReference, silent: Bool = false) throws { | |||
There was a problem hiding this comment.
I'm not super happy with that solution to silent the method.. Maybe it would be cleaner to inject output. as. an optional parameter into the functions?
| return | ||
| } | ||
| for (name, value) in outdatedPackages { | ||
| try install(package: value.newReference, executable: name, force: true, link: true) |
There was a problem hiding this comment.
I'm not 100% sure if I need to provide the executable name here
|
Hi @lennet. Thanks for the PR, they are some great additions! I’m on holidays somewhere remote till the 30th so won’t have time to look at this properly till then. |
|
Hope you had great holidays! Yes, currently these command only check linked packages. Should I include packages that are installed via a Mintfile in the same command or add a separate command or argument for it? |
|
Hi @yonaskolb. These additions look very promising, and I’m sure would be a welcome addition to mint by the community. Have you had a chance to look at this PR recently? Is there anything one could do to get it into a merge-ready state? |
|
@yonaskolb I recently submitted an issue (#174) and the happened to check what the open PRs are for here. Whatever happened with this? |
|
Sorry to dig this up again, but it looks like this PR was forgotten? |
This PR adds two commands:
fixes #87, #121