[feature] Add launcher shutdown hook #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmannibucau
reviewed
Feb 1, 2025
| try (final var launcher = new Launcher(args)) { | ||
| Configuration configuration = launcher.container.lookup(Configuration.class).instance(); | ||
| useHook.set(Boolean.parseBoolean(configuration.get("fusion.launcher.useHook").orElse("false"))); |
There was a problem hiding this comment.
No need of a field instance, can be a local final boolean
rmannibucau
reviewed
Feb 1, 2025
| @@ -130,6 +130,9 @@ TIP: listening to `Start` event can enable a lazy instance (`@ApplicationScoped` | |||
|
|
|||
| TIP: an event can have more parameters, other parameters will be considered as injections (but the lookup will be destroyed after the method call if it is not `@ApplicationScoped`) | |||
|
|
|||
| TIP: When using the Launcher provided by the Fusion, you can use the shutdown hook to call the `container.close()` method and send the `Stop` event by settings the system properties | |||
There was a problem hiding this comment.
Maybe mention "fusion configuration", ie system props, env var (useful for k8s).
Can also be worth mentioning signals it maps to (still k8s case)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.