fix(plantuml): pass plantuml.include.path property to native plantuml binary #1828
+12
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have found a way of passing the
plantuml.include.path
property to the native plantuml library.It's worth noting that, plantuml has a
-D
parameter which sets value of global preprocessing variable as described here: https://plantuml.com/command-line, however when built using GraalVM into native library, the GraalVM handling of the-D
parameter (described here: https://www.graalvm.org/latest/reference-manual/native-image/guides/use-system-properties/) takes precedence, which is the reason why this fix works.I have added debug log message to add ability to see the exact plantuml command parameters which makes it easier to debug any problems with it, if necessary.
Please let me know what do you think.
Fixes #1765