feat: add fallback for get login.keyring path #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szuecs
reviewed
Aug 23, 2024
| var loginAlias dbus.ObjectPath | ||
| err := s.object.Call(serviceInterface+".ReadAlias", 0, "login").Store(&loginAlias) | ||
| if err != nil || loginAlias == "/" { | ||
| path = dbus.ObjectPath(loginCollectionAlias) |
There was a problem hiding this comment.
If the PR is about adding a fallback I would assume that the current behavior stays the same and the new thing is the fallback. Here we have it the other way around.
Maybe it's good, I don't know the details and give the impact for >1000 projects that use this library, I would like to have a reason why we change the order.
|
please sign-off your commit such that DCO check is green |
Signed-off-by: lichangze <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we can get login.keyring dbus path by call ReadAlias