Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: better support different number of rings #113

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ggarber
Copy link
Contributor

@ggarber ggarber commented Apr 2, 2023

Better support for variable number of rings removing the hardcoded constant 4 in different places.

@bocytko
Copy link
Member

bocytko commented Apr 2, 2023

Thanks for the PR. Do you have a branch with a fully working example?
I tried to check out your branch and add a 5th ring and the change breaks due to undefined radius for the new ring.

A few more things will break:

  • cartesian_max uses index 3 which is a hardcoded 4-1
  • legend_calculation calculates the legend offsets and at least the calculation for dy needs to consider more rings via a formula with ring and 12 rather than the naive switch using mod 2

@rishiraj88
Copy link

Nice idea, going forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants