Do not write files in user system #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stops sysinfo from writing files in the running system without telling the user about it. A system with no machine-id is a completely valid system and can be like that at different times, like inside a container, on a first boot, in immutable systems, etc... We should not write files in teh user system without informing them and not having a machine-id is a valid state. Signed-off-by: Itxaka <[email protected]>
|
@zcalusic any comment on this? |
|
I agree that nowadays we probably should not tamper with the machine ID. This was added a long time ago to better support some ancient distributions that were unaware of the machine ID. However, in the meantime, we have dropped support for those, so it's okay if this workaround is removed as well. Thank you for your contribution @Itxaka! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This stops sysinfo from writing files in the running system without telling the user about it.
A system with no machine-id is a completely valid system and can be like that at different times, like inside a container, on a first boot, in immutable systems, etc...
We should not write files in teh user system without informing them and not having a machine-id is a valid state.
Fixes: #42