-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to incrementalmerkletree 0.8
, shardtree 0.6
#1692
base: main
Are you sure you want to change the base?
Conversation
Cargo.toml
Outdated
orchard = { git = "https://github.com/zcash/orchard.git", rev = "b1c22c07300db22239235d16dab096e23369948f" } | ||
redjubjub = { git = "https://github.com/ZcashFoundation/redjubjub", rev = "eae848c5c14d9c795d000dd9f4c4762d1aee7ee1" } | ||
sapling = { package = "sapling-crypto", git = "https://github.com/zcash/sapling-crypto.git", rev = "e607c52d13bb7ade66293f9ab8d07e311f4ad868" } | ||
sapling = { package = "sapling-crypto", git = "https://github.com/zcash/sapling-crypto.git", rev = "6ca338532912adcd82369220faeea31aab4720c5" } | ||
incrementalmerkletree = { git = "https://github.com/zcash/incrementalmerkletree.git", rev = "44065917a399a921a2151bd14d399a192eb61960" } | ||
incrementalmerkletree-testing = { git = "https://github.com/zcash/incrementalmerkletree.git", rev = "44065917a399a921a2151bd14d399a192eb61960" } | ||
shardtree = { git = "https://github.com/zcash/incrementalmerkletree.git", rev = "44065917a399a921a2151bd14d399a192eb61960" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have not checked these commit hashes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far.
34616c0
to
2de9260
Compare
Not reviewing because it's still failing tests. |
2de9260
to
6cf0806
Compare
6cf0806
to
c19f8cd
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1692 +/- ##
==========================================
- Coverage 54.36% 54.33% -0.03%
==========================================
Files 173 173
Lines 20274 20282 +8
==========================================
Hits 11021 11021
- Misses 9253 9261 +8 ☔ View full report in Codecov by Sentry. |
c19f8cd
to
fc306e9
Compare
fc306e9
to
1b2dab2
Compare
No description provided.