add SigningParts getters #433
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conradoplg
force-pushed
the
signing-parts-getters
branch
from
4ffcf2c to
5b611bf
Compare
conradoplg
force-pushed
the
signing-parts-getters
branch
from
5b611bf to
f0c88b7
Compare
str4d
requested changes
Feb 21, 2025
| @@ -334,6 +334,15 @@ impl From<FullViewingKey> for SpendValidatingKey { | |||
| } | |||
|
|
|||
| impl FullViewingKey { | |||
| /// Create FVK from the given sk and ak. | |||
| pub fn from_sk_ak(sk: &SpendingKey, ak: SpendValidatingKey) -> Self { | |||
There was a problem hiding this comment.
The documentation here is very insufficient:
- It makes no mention of how
skandakare checked or combined (in particular, that you get a different FVK than if you just go fromsk). - It makes no mention of FROST (or why you would want to use this API).
- It is not behind a feature flag so is exposing a normative public API which I do not want to be present without a corresponding specification (which will eventually be ZIP 312 once [ZIP 312] Key generation zips#883 is finished).
Also, not documented as an addition in the changelog.
| &self.ak | ||
| } | ||
| /// Return the randomization for this action. | ||
| pub fn alpha(&self) -> pallas::Scalar { |
There was a problem hiding this comment.
These getters are only necessary for the older compile-time state machine builder API. Since this PR was opened, we've deployed PCZTs which already include these getters implicitly, and PCZTs (and runtime state machine builder APIs in general) are the general direction we will be heading, so these aren't technically necessary. That being said, as these are behind an unstable feature flag I wouldn't mind them going in for testing purposes, on the understanding that they likely will eventually be removed (along with the corresponding builder logic).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #428
See #430 for rationale