Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZIPs 226, 227, and 230: ZSA Transfer, Issuance and Burn #976

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

vivek-arte
Copy link
Contributor

@vivek-arte vivek-arte commented Feb 6, 2025

This PR continues the discussion on the ZSA ZIPs from the previous #960 , all but the last commit of which was merged in #974.

It contains any recent changes to the following ZIPs:

ZIP 226: Transfer and Burn of Zcash Shielded Assets
ZIP 227: Issuance of Zcash Shielded Assets
ZIP 230: Version 6 Transaction Format

Note that the target issue for the ZSA ZIPs is #618.

The changes include:

  • Movement of the burn information from outside the Action Group to inside the Action Group
  • Renaming of some sub-branches of the txid_digest and signature_digest and auth_digest trees for clearer OrchardZSA separation.

This shifts the information pertaining to the burning of assets into
the OrchardZSA Action Group -- this occurs both in the Transaction
Format and the computation of the TxID digest.
This merges the changes to the repository upstream into the `zsa1`
branch
@vivek-arte
Copy link
Contributor Author

One of the changes in this PR shifts the information pertaining to the burning of assets into the OrchardZSA Action Group -- this occurs both in the Transaction Format and the computation of the TxID digest. A pictorial summary of this is included in this comment:

image

The above image shows, on the left, the structure of the OrchardZSA bundle before this PR, and on the right, the changes made to include the burn information into the Action Groups. The image below shows the changes that are to be made correspondingly to the digests:

image

This performs various improvements to the naming of the branches of
the TxID and Signature Digests, and the Authorizing Data Commitment, as
initially suggested in the review of
QED-it/zcash-test-vectors#24.
@vivek-arte
Copy link
Contributor Author

I also just pushed a commit which makes various improvements to the naming of the sub-branches of the TxID and Signature Digests, and the Authorizing Data Commitment. The pictures below give a quick overview of these changes.

image
image

@str4d
Copy link
Collaborator

str4d commented Feb 26, 2025

FYI we pulled in the renaming commit into #987 because of the changes it implicitly made to where the sighash parts suggested by qedit were located, but we have reverted the renaming therein because it does not make sense once moved into the context of ZIP 246.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants