-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ZEA-4591: Lock available Node.js version on major version #428
base: main
Are you sure you want to change the base?
ZEA-4591: Lock available Node.js version on major version #428
Conversation
05e6f3a
to
85ec235
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
85ec235
to
b60563b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
internal/nodejs/plan_test.go:43
- Remove the comment
// FIXME: should be the latest?
to avoid confusion about the expected behavior.
assert.Equal(t, strconv.FormatUint(maxNodeVersion, 10), v) // FIXME: should be the latest?
internal/nodejs/plan.go:551
- [nitpick] The variable name
versionConstraint
was renamed toconstraint
. Ensure consistent naming across the codebase.
func getNodeVersion(constraint string) string {
Description (required)
Related issues & labels (optional)