Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZEA-4591: Lock available Node.js version on major version #428

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

pan93412
Copy link
Member

@pan93412 pan93412 commented Feb 9, 2025

Description (required)

  • refactor(planner/nodejs): Update Node.js version
  • feat(planner/nodejs): Implement getNodeVersion that only extracts major version

Related issues & labels (optional)

  • Closes ZEA-4591
  • Suggested label: enhancement

@pan93412 pan93412 self-assigned this Feb 9, 2025
@pan93412 pan93412 force-pushed the pan93412/zea-4591-lock-available-nodejs-version-on-major-version branch from 05e6f3a to 85ec235 Compare February 9, 2025 07:59
@pan93412 pan93412 requested a review from Copilot February 9, 2025 08:00
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.

internal/nodejs/plan.go Outdated Show resolved Hide resolved
internal/nodejs/plan.go Outdated Show resolved Hide resolved
internal/nodejs/plan.go Outdated Show resolved Hide resolved
internal/nodejs/plan.go Outdated Show resolved Hide resolved
internal/nodejs/plan.go Outdated Show resolved Hide resolved
@pan93412 pan93412 force-pushed the pan93412/zea-4591-lock-available-nodejs-version-on-major-version branch from 85ec235 to b60563b Compare February 9, 2025 08:07
@pan93412 pan93412 requested a review from Copilot February 9, 2025 08:07

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

internal/nodejs/plan_test.go:43

  • Remove the comment // FIXME: should be the latest? to avoid confusion about the expected behavior.
assert.Equal(t, strconv.FormatUint(maxNodeVersion, 10), v) // FIXME: should be the latest?

internal/nodejs/plan.go:551

  • [nitpick] The variable name versionConstraint was renamed to constraint. Ensure consistent naming across the codebase.
func getNodeVersion(constraint string) string {
@pan93412 pan93412 requested a review from yuaanlin February 9, 2025 08:10
Base automatically changed from pan93412/zea-4590-implement-our-own-corepack to main February 9, 2025 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant