CI updates #33
Merged
CI updates #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove Fedora 36 & 37, add 38 & 39 - Remove Ubuntu 18 - Remove macOS Monterey, add Sonoma - Remove openSUSE Leap 15.4, add 15.5 - Add Debian 12 - Take FreeBSD 14 out of test-only mode, bump 13.1 to 13.2, remove 12
awelzel
approved these changes
Dec 14, 2023
There was a problem hiding this comment.
Let me naively ask why we're building binpac so elaborately in its own repo? Isn't that mostly (and much better) covered once the submodule is bumped over in Zeek? There isn't a single test in this repo from what I can tell and I can hardly picture someone using BinPac standalone.
@timwoj - seems you added it early this year. Any main driver?
Could a single distro be enough (and could consider switching to a GitHub action, too).
|
I added it because I was doing work in the repo and it was easier to make it build itself than to update a Zeek branch and wait for all of Zeek to build. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Companion to zeek/zeek#3502.