Skip to content

Commit

Permalink
Refactor Surfer CI commands in workflows for consistency and improved…
Browse files Browse the repository at this point in the history
… readability
  • Loading branch information
mauro-balades committed Feb 3, 2025
1 parent 24d8e7a commit b1b83ae
Show file tree
Hide file tree
Showing 7 changed files with 10 additions and 10 deletions.
8 changes: 4 additions & 4 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -153,12 +153,12 @@ jobs:
- name: Bump version
if: ${{ inputs.update_version && inputs.update_branch == 'release' }}
run: |
npm run surfer ci --brand ${{ inputs.update_branch }} --bump prerelease
npm run surfer -- ci --brand ${{ inputs.update_branch }} --bump prerelease
- name: Bump version without new version
if: ${{ !inputs.update_version || inputs.update_branch == 'twilight' }}
run: |
npm run surfer ci --brand ${{ inputs.update_branch }}
npm run surfer -- ci --brand ${{ inputs.update_branch }}
- name: Debug
run: |
Expand Down Expand Up @@ -213,7 +213,7 @@ jobs:
- name: Activate Surfer CLI
run: |
echo "There's a bug in the Surfer CLI, we run this so that Surfer sets everything up correctly"
npm run surfer ci --brand ${{ inputs.update_branch }} --display-version ${{ needs.build-data.outputs.version }}
npm run surfer -- ci --brand ${{ inputs.update_branch }} --display-version ${{ needs.build-data.outputs.version }}
- name: Check version
run: |
Expand Down Expand Up @@ -255,7 +255,7 @@ jobs:
npm install
- name: Load Surfer CI setup
run: npm run surfer ci --brand ${{ inputs.update_branch }} --display-version ${{ needs.build-data.outputs.version }}
run: npm run surfer -- ci --brand ${{ inputs.update_branch }} --display-version ${{ needs.build-data.outputs.version }}

- name: Download Firefox source and dependencies
run: npm run download --verbose
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/linux-release-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ jobs:
npm install
- name: Load Surfer CI setup
run: npm run surfer ci --brand ${{ inputs.release-branch }} --display-version ${{ inputs.build-version }}
run: npm run surfer -- ci --brand ${{ inputs.release-branch }} --display-version ${{ inputs.build-version }}

- name: Download Firefox source and dependencies
run: npm run download
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/macos-release-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ jobs:
npm install
- name: Load surfer CI setup
run: npm run surfer ci --brand ${{ inputs.release-branch }} --display-version ${{ inputs.build-version }}
run: npm run surfer -- ci --brand ${{ inputs.release-branch }} --display-version ${{ inputs.build-version }}

- name: Download Firefox source and dependencies
run: npm run download
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/macos-universal-release-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ jobs:
npm install
- name: Load surfer CI setup
run: npm run surfer ci --brand ${{ inputs.release-branch }} --display-version ${{ inputs.build-version }}
run: npm run surfer -- ci --brand ${{ inputs.release-branch }} --display-version ${{ inputs.build-version }}

- name: Download Firefox source and dependencies
run: npm run download
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/windows-profile-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ jobs:
run: npm i -g @zen-browser/surfer

- name: Load Surfer CI setup
run: npm run surfer ci --brand ${{ inputs.release-branch }} --display-version ${{ inputs.build-version }}
run: npm run surfer -- ci --brand ${{ inputs.release-branch }} --display-version ${{ inputs.build-version }}

- name: Download artifact
if: ${{ matrix.arch == 'x86_64' }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/windows-release-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ jobs:
sudo apt-get install -y python3 python3-pip dos2unix yasm nasm build-essential libgtk2.0-dev libpython3-dev m4 uuid libasound2-dev libcurl4-openssl-dev libdbus-1-dev libdrm-dev libdbus-glib-1-dev libgtk-3-dev libpulse-dev libx11-xcb-dev libxt-dev xvfb lld llvm --fix-missing
- name: Load Surfer CI setup
run: npm run surfer ci --brand ${{ inputs.release-branch }} --display-version ${{ inputs.build-version }}
run: npm run surfer -- ci --brand ${{ inputs.release-branch }} --display-version ${{ inputs.build-version }}

- name: Download Firefox and dependencies
if: ${{ !(inputs.generate-gpo && matrix.arch == 'aarch64') }}
Expand Down
2 changes: 1 addition & 1 deletion build/winsign/sign.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ echo "Downloaded x86_64 artifacts"

mkdir engine\obj-x86_64-pc-windows-msvc\ -ErrorAction SilentlyContinue

npm run surfer ci --brand release
npm run surfer -- ci --brand release

function SignAndPackage($name) {
echo "Executing on $name"
Expand Down

0 comments on commit b1b83ae

Please sign in to comment.