Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a more complete JXL features #5634

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

noaione
Copy link

@noaione noaione commented Feb 23, 2025

@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. Feature labels Feb 23, 2025
@noaione
Copy link
Author

noaione commented Feb 24, 2025

I just realized that 136.0 is coming out next week, I'll rebase/check this again when it's out later.

@mauro-balades
Copy link
Member

Please do! <3

@noaione noaione force-pushed the complete-jxl-support branch from 1ca03d5 to 308e670 Compare February 26, 2025 12:55
@noaione
Copy link
Author

noaione commented Feb 26, 2025

I create a separate branch for testing RC 136.0, commit with all the updates: noaione@d532a0a
Action run: https://github.com/noaione/zen-desktop/actions/runs/13545212849

I can make a separate PR that only upgrade stuff to RC 136.0 if you want.

EDIT: Cancelling workflow, I think I accidentally removed some stuff when updating

@noaione
Copy link
Author

noaione commented Feb 26, 2025

@noaione noaione changed the title Implement a more complete JXL implementation Implement a more complete JXL features Feb 26, 2025
@mauro-balades
Copy link
Member

@noaione i've rebased zen into 136 now 👍🏽

@noaione noaione force-pushed the complete-jxl-support branch from 308e670 to 34b0c8e Compare February 26, 2025 23:01
@noaione
Copy link
Author

noaione commented Feb 26, 2025

Force pushed again, I've rebuild it with your RC changes: https://github.com/noaione/zen-desktop/actions/runs/13555078895

zen_BzycI4h9Dx.mp4

Demo above using my changes, everything still works fine and nothing needs to be changed in this PR

@noaione
Copy link
Author

noaione commented Feb 26, 2025

And the progressive decoding demo, currently it needs around ~15-20% minimum for it to start to showing something

zen_Ku2w8yrn6c.mp4

@noaione
Copy link
Author

noaione commented Feb 26, 2025

@mauro-balades Looks like you need to bump the Rust toolchain/Setup rust to 1.81 at minimum.
cargo-download depends on litemap which now have MSRV of 1.81.0 as of 5 hours ago

https://github.com/noaione/zen-desktop/actions/runs/13555078895/job/37887547273#step:13:284

Copy link
Member

@mauro-balades mauro-balades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Btw, why didn't firefox aprove these patches?

name = "mime_guess"
version = "2.0.4"
-source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "4192263c238a5f0d0c6bfd21f336a313a4ce1c450542449ca191bb657b4642ef"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this patch?

Copy link
Author

@noaione noaione Feb 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The crates is overridden by a local copy (vendored), so if we have source and checksum it will just fails when compiling because of mismatched checksum/source.

https://github.com/zen-browser/desktop/pull/5634/files#diff-f731af816322ebd573c87e5f1e2af1c4e674c4fee3c61dd9084364f4bc57b1beR9

@noaione
Copy link
Author

noaione commented Feb 28, 2025

Looks good! Btw, why didn't firefox aprove these patches?

I think:

  1. Patch got stalled and no progress
  2. Google decide to not support JXL anymore (so Mozilla also stopped)
  3. Mozilla recently decide to support adding JXL if someone will made Rust implementation of it. (https://mozilla.github.io/standards-positions/#jpegxl)

For the rust (re)implementation, I think they're working it here: https://github.com/libjxl/jxl-rs
We can remove this patch whenever upstream decide to finally implement JXL with the Rust implementation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature size:XL This PR changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Complete JPEG-XL Support
2 participants