-
-
Notifications
You must be signed in to change notification settings - Fork 654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement a more complete JXL features #5634
base: dev
Are you sure you want to change the base?
Conversation
I just realized that 136.0 is coming out next week, I'll rebase/check this again when it's out later. |
Please do! <3 |
1ca03d5
to
308e670
Compare
I create a separate branch for testing RC 136.0, commit with all the updates: I can make a separate PR that only upgrade stuff to RC 136.0 if you want. EDIT: Cancelling workflow, I think I accidentally removed some stuff when updating |
Newer commit: noaione@76d8ddd |
@noaione i've rebased zen into 136 now 👍🏽 |
Based on this following phabricator patch/commits: - https://phabricator.services.mozilla.com/D119700 - https://phabricator.services.mozilla.com/D122158 - https://phabricator.services.mozilla.com/D122159 Which add the following: - Proper color profiles support for JPEG XL - Animated JPEG XL - Progressive decoding Co-authored-by: wwwwwwww <[email protected]>
308e670
to
34b0c8e
Compare
Force pushed again, I've rebuild it with your RC changes: https://github.com/noaione/zen-desktop/actions/runs/13555078895 zen_BzycI4h9Dx.mp4Demo above using my changes, everything still works fine and nothing needs to be changed in this PR |
And the progressive decoding demo, currently it needs around ~15-20% minimum for it to start to showing something zen_Ku2w8yrn6c.mp4 |
@mauro-balades Looks like you need to bump the Rust toolchain/Setup rust to 1.81 at minimum. https://github.com/noaione/zen-desktop/actions/runs/13555078895/job/37887547273#step:13:284 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Btw, why didn't firefox aprove these patches?
name = "mime_guess" | ||
version = "2.0.4" | ||
-source = "registry+https://github.com/rust-lang/crates.io-index" | ||
-checksum = "4192263c238a5f0d0c6bfd21f336a313a4ce1c450542449ca191bb657b4642ef" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this patch?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The crates is overridden by a local copy (vendored), so if we have source and checksum it will just fails when compiling because of mismatched checksum/source.
I think:
For the rust (re)implementation, I think they're working it here: https://github.com/libjxl/jxl-rs |
Based on this following phabricator patch/commits:
Rebased for FF 136.0 RC code
Which add the following:
Also added the following: https://src.fedoraproject.org/fork/eclipseo/rpms/firefox/blob/90702891fefc97ff9e347dbab0091136822a0f3b/f/0002-Bug-1539075-Register-.jxl-extension-in-Firefox.-r-tn.patch
Fix #726
zen_4RjRNpUxaH.mp4
Tested on: https://jpegxl.info/resources/jpeg-xl-test-page.html and https://google.github.io/attention-center/ (Progressive demo)
Demo build: https://nightly.link/noaione/zen-desktop/actions/runs/13485116765