Fix: fixed overflowing glance buttons when sidebar is opened #5842
+87
−51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:L
| @@ -283,9 +318,8 @@ | |||
| return; | |||
| } | |||
|
|
|||
| if (!onTabClose || quikcCloseZen) { | |||
| this.quickCloseGlance({ clearID: false }); | |||
| } | |||
There was a problem hiding this comment.
more streamlined approach to closing
There was a problem hiding this comment.
But have you tested this fully? The check is done for a reason...
There was a problem hiding this comment.
Ye like 15 times, tried to break it. you can try it locally urself
There was a problem hiding this comment.
lmk if you want to bring the checks back its no big deal , just thought this approach is more understandable
| @@ -325,6 +359,10 @@ | |||
| this._animating = false; | |||
| this.closingGlance = false; | |||
|
|
|||
| // Hide the buttons globally whenever we close | |||
| this.hideSidebarButtons(); | |||
There was a problem hiding this comment.
This is already closed from the quickCloseGlance method
There was a problem hiding this comment.
just a safety measure just to be sure buttons are hidden
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added informative comments for the glance component + refactored hideous stacked else ifs