Feat/next 13 #20
Open
Feat/next 13 #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 6, 2023 15:08
Use next 13 app router feature to enable React Server Components. This allows to render and cache components on the server even if they are children of components rendered client side.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates next to its last version which move the App router out of experimental features.
It is now the recommended routing and I moved around files to match this new routing implementation.
This App router brings server components support which is very useful for us to cache the html markup generated when rendering the talks. This way, the user won't have to wait the google sheet call at each refresh. It was about a second long and led to a page interactive in about 3 seconds.
The downside is that we always present cached values to the user. This cache is invalidated on next request after 10 secs though. As long as we have enough users, one will see an update lag of about 10secs. Realistically with an app usage pretty low, the user will lag behind multiple hours.
If one searches for a specific talk, they might think about refreshing 🤞. If they are just here browsing content, they'll possibly miss the latest content (it's a shame but I think it's ok though).