Add cookie banner #115
Merged
Add cookie banner #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlinmack
force-pushed
the
759-cookie-banner
branch
from
cb0d481 to
afb7f7b
Compare
11 tasks
ptamarit
approved these changes
Mar 25, 2024
carlinmack
force-pushed
the
759-cookie-banner
branch
from
2551790 to
53a2772
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close zenodo/zenodo-rdm#759
Currently the Matomo tracking code is repeated in individual templates (base-about.html, base-blog.html, base-help.html etc)
This PR refactors these repeated code blocks into a macro which passes the site ID for the analytics and introduces tracking to the pages which had been forgotten.
Additionally the cookie banner from zenodo/zenodo-rdm#766 is introduced. As we don't have Semantic UI, I have imported the minimal set of styles to make it look okay and adjusted the Javascript to not use Semanic UI's
.fade. Finally we set the cookie on.zenodo.orgrather than/so that the cookie works across domains.Note: do we need to link to cookie policy on https://developers.zenodo.org/? I believe we don't use tracking cookies here