support form: add support for pdf files #656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kpsherva
approved these changes
Nov 16, 2023
slint
reviewed
Nov 20, 2023
| @@ -165,7 +165,7 @@ class SupportForm extends Component { | |||
| }); | |||
| }, | |||
| maxSize: maxFileSize, | |||
| accept: ".jpeg,.jpg,.png", | |||
| accept: ".jpeg,.jpg,.png,.pdf", | |||
There was a problem hiding this comment.
Suggested change
| accept: ".jpeg,.jpg,.png,.pdf", |
TBH, I'm not sure why we are limiting the accepted file types. I would just accept anything (imagine e.g. a user wanting to replace a README.md file).
jennur
force-pushed
the
support-file-types
branch
from
7b2aef6 to
93a011f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/zenodo/rdm-project/issues/531