-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mcuboot: Add support for swap using offset algorithm #83893
Conversation
The following west manifest projects have changed revision in this Pull Request:
Additional metadata changed:
⛔ DNM label due to: 1 project with metadata changes Note: This message is automatically posted and updated by the Manifest GitHub Action. |
3ad19c7
to
f9224a0
Compare
9990c03
to
feaeb92
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed part with tests, looks good.
Our internal regression passed (upgrade tests on nRF boards)
7599ddb
to
a89ba0f
Compare
Update Zephyr fork of MCUboot to revision: 9a02794a14fa2e539ffe039a986360590d9e025f Brings following Zephyr relevant fixes: - 9a02794a boot: bootutil: swap_offset: Skip erasing/copying empty sectors - 96b70086 zephyr: Fix image encryption configuration for mbedTLS. - e5b89529 boot: boot_serial: Add support for swap using offset mode - 18fee817 zephyr: Add support for swap using offset mode - 4af73169 boot: bootutil: Add swap using offset algorithm - 9668469f zephyr: Add Kconfig option to select PureEdDS - 96f01aad zephyr: Add Kconfig and configuration for SHA on storage - 30e6adfe zephyr: Allow SHA512 with TinyCrypt - de9bc3d0 bootutil: PureEdDSA using ED25519 - b43b8c80 bootutil: Enable hash calculation directly on storage - f72158ff bootutil: Allow SHA512 with TinyCrypt - 4b8a37bb zephyr: Add imgtool/cbor to pip packages installed by west - 3f672134 zephyr: Fix usage of CONFIG_MBEDTLS_BUILTIN and ASN1 - c6f5db29 bootutil: Add missing MBEDTLS_ASN1_PARSE_C Signed-off-by: Jamie McCrae <[email protected]>
Adds a new Kconfig for selecting swap using move in MCUboot which aligns with the proper MCUboot symbol and allows for adding additional mode Kconfigs Signed-off-by: Jamie McCrae <[email protected]>
Deprecates the old Kconfig and adds a new one which lines up with the name of the Kconfig used by MCUboot Signed-off-by: Jamie McCrae <[email protected]>
Allows using this newly introduced MCUboot algorithm Signed-off-by: Jamie McCrae <[email protected]>
Adds a new Kconfig to allow selecting this newly introduced MCUboot swapping algorithm Signed-off-by: Jamie McCrae <[email protected]>
Adds details on how to select this new operating mode when using and when not using sysbuild, also includes a note about a Kconfig being deprecated and the name of the replacement symbol Signed-off-by: Jamie McCrae <[email protected]>
Adds a Kconfig used for configuring MCUboot to the allow list Signed-off-by: Jamie McCrae <[email protected]>
Adds a variation of the test which tests swap using offset mode, based on the swap using move test Signed-off-by: Jamie McCrae <[email protected]>
Adds a variation of the test which tests swap using offset mode, based on the swap using move test Signed-off-by: Jamie McCrae <[email protected]>
a89ba0f
to
8f29524
Compare
@butok that issue should be fixed now, can you try again? |
If you are able to build it on your system, it's my local problem => ignore my issue. |
Builds here:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor issue, but doesn't warrant re-doing the patch if nothing else needs to change.
#elif defined(CONFIG_MCUBOOT_BOOTLOADER_MODE_SWAP_USING_OFFSET) | ||
#define BOOTLOADER_MODE MCUBOOT_MODE_SWAP_USING_OFFSET | ||
#elif defined(CONFIG_MCUBOOT_BOOTLOADER_MODE_SWAP_USING_MOVE) || \ | ||
defined(CONFIG_MCUBOOT_BOOTLOADER_MODE_SWAP_WITHOUT_SCRATCH) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would be a lot nicer to indent the second line. Not urgent enough, but if you have to fix it for something else.
This new mode offers a faster update time and erase a whole round of sector erases/writes from the primary slot
Split MCUboot PR update due to commit being in #83294