soc: nxp: Make clock init weak and global #84629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
requested review from
butok,
dbaluta,
DerekSnell,
dleach02,
EmilioCBen,
iuliana-prodan,
JiafeiPan,
mmahadevan108 and
yvanderv
butok
previously approved these changes
Jan 28, 2025
soc/nxp/imx/imx8m/a53/soc.c
Outdated
| @@ -58,7 +58,7 @@ static void soc_rdc_init(void) | |||
|
|
|||
| #endif | |||
|
|
|||
| static void soc_clock_init(void) | |||
| void __weak soc_clock_init(void) | |||
There was a problem hiding this comment.
Be consistent and use __weak before void always, like __weak void clock_init()
Raymond0225
approved these changes
Jan 29, 2025
Make clock init functions in SOC level weak and global so they can be overriden by board/app level. Ideally these should have been put at board level but for now just make them weak so they can be overriden without breaking anything. Signed-off-by: Declan Snyder <[email protected]>
decsny
force-pushed
the
nxp_soc_clock_weaks
branch
from
41ecfea to
ac140fc
Compare
butok
approved these changes
Feb 5, 2025
JiafeiPan
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make clock init functions in SOC level weak and global so they can be overriden by board/app level.
Ideally these should have been put at board level but for now just make them weak so they can be overriden without breaking anything.
Fixes #64515