Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boards: mimxrt1170_evk: switch the default revision to B #85233

Merged

Conversation

butok
Copy link
Contributor

@butok butok commented Feb 5, 2025

Switches the default revision of mimxrt1170_evk from A to B.
Customers can only purchase MIMXRT1170-EVKB.
Revision "A" is obsolete and unavailable.

@zephyrbot zephyrbot added platform: NXP NXP size: XS A PR changing only a single line of code labels Feb 5, 2025
dleach02
dleach02 previously approved these changes Feb 5, 2025
@butok
Copy link
Contributor Author

butok commented Feb 6, 2025

PR found an error in samples/sensor/mcux_acmp.
It should be fixed by #85274

@dleach02
Copy link
Member

dleach02 commented Feb 7, 2025

I believe you need to add a specifically named overlay file for rev B in the samples/sensor/mcux_acmp/boards/

I would do a global scan for any others.

@butok butok force-pushed the mimxrt1170_EVKB_default branch from b55502d to 66d8c32 Compare February 10, 2025 10:47
@butok
Copy link
Contributor Author

butok commented Feb 10, 2025

I believe you need to add a specifically named overlay file for rev B in the samples/sensor/mcux_acmp/boards/

As documented, the Rev. B does not support ACMP: https://docs.zephyrproject.org/latest/boards/nxp/mimxrt1170_evk/doc/index.html#supported-features

@butok
Copy link
Contributor Author

butok commented Feb 10, 2025

Hm. Strange behavior of CI: https://github.com/zephyrproject-rtos/zephyr/actions/runs/13239076808/job/36950204779?pr=85233
unrecognized platform - mimxrt1170_evk@A/mimxrt1176/cm7
But I am able to be build locally : west build -p always -b mimxrt1170_evk@A/mimxrt1176/cm7 samples/sensor/mcux_acmp

@butok
Copy link
Contributor Author

butok commented Feb 10, 2025

Hm. Strange behavior of CI: https://github.com/zephyrproject-rtos/zephyr/actions/runs/13239076808/job/36950204779?pr=85233 unrecognized platform - mimxrt1170_evk@A/mimxrt1176/cm7 But I am able to be build locally : west build -p always -b mimxrt1170_evk@A/mimxrt1176/cm7 samples/sensor/mcux_acmp

Solved.

Switches the default revision of mimxrt1170_evk from A to B.
Customers can only purchase MIMXRT1170-EVKB.
Revision "A" is obsolete and unavailable.

Signed-off-by: Andrej Butok <[email protected]>
@butok butok force-pushed the mimxrt1170_EVKB_default branch from f04051d to c2246ba Compare February 10, 2025 15:59
@zephyrbot zephyrbot added the area: DMA Direct Memory Access label Feb 10, 2025
@zephyrbot zephyrbot requested a review from teburd February 10, 2025 16:00
@mmahadevan108
Copy link
Collaborator

@hakehuang , can you help run a test on this PR for RT1170 EVK?

@kartben kartben merged commit 95b74e2 into zephyrproject-rtos:main Feb 13, 2025
21 checks passed
@hakehuang
Copy link
Collaborator

@hakehuang , can you help run a test on this PR for RT1170 EVK?

I add this platform and update in board farm. and start regression on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: DMA Direct Memory Access platform: NXP NXP size: XS A PR changing only a single line of code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants