samples: minimal: refactor meta data #85446
Conversation
|
with this change there is a minor issue for qemu_x86_64_atom.
|
hakehuang
force-pushed
the
refactor_minial_config
branch
2 times, most recently
from
8038ae1 to
fec42e1
Compare
try
why is this needed? what do we get out of this? |
| extra_args: CONF_FILE='common.conf;mt.conf;arm.conf' | ||
| sample.minimal.mt: | ||
| arch_allow: | ||
| - arm |
There was a problem hiding this comment.
why arch_allow is good but not platform_allow?
There was a problem hiding this comment.
why
arch_allowis good but notplatform_allow?
This is better than adding a list of all arm and x86 boards.
There was a problem hiding this comment.
I find arc and riscv has its own minimal test config already. so my assumption is that the minimal setting config is arch depended.
sample.minimal.arc.runtime:
extra_args:
- CONF_FILE='common-runtime.conf;no-timers.conf'
arch_allow: arc
tags:
- kernel
integration_platforms:
- qemu_arc/qemu_arc_em
sample.minimal.riscv.runtime:
extra_args:
- CONF_FILE='common-runtime.conf;no-timers.conf;no-mt.conf;riscv.conf'
platform_allow: qemu_riscv32
tags:
- kernel
integration_platforms:
- qemu_riscv32
zephyrbot
requested review from
butok,
Dat-NguyenDuy,
decsny,
DerekSnell,
dleach02,
EmilioCBen,
manuargue and
mmahadevan108
There are 3 reasons on enable this for general.
Below are closed as venders do not plan to support #85560 is founded. and there are more issues found by this setting, I will report them. |
sure. I am testing many config confliction found, I will report. |
|
@nashif I add fixes for integration platforms, and some of NXP platforms. please review. Thanks |
remove platform_allow, extend integration_platform Signed-off-by: Hake Huang <[email protected]>
if CONFIG_SYS_CLOCK_HW_CYCLES_PER_SEC is not config a default value, it will just defined, and will have below error zephyr/include/zephyr/sys_clock.h:158:45: error: operator '==' has no left operand 158 | (CONFIG_SYS_CLOCK_HW_CYCLES_PER_SEC == 0) Signed-off-by: Hake Huang <[email protected]>
fix a printk dependency issue printk.c:33:26: error: 'lock' defined but not used Signed-off-by: Hake Huang <[email protected]>
hakehuang
force-pushed
the
refactor_minial_config
branch
from
4b94e58 to
3e274ef
Compare
zephyrbot
added
platform: STM32
This is only for minimal, as discussion in the #85359, we can not remove the platform_allow, and we do not want this to be kept adding. Then tag is the only way to move platforms in, for now only, integration_platform and NXP platforms are enabled. |
hakehuang
force-pushed
the
refactor_minial_config
branch
from
3e274ef to
2d2d2a0
Compare
The discussion in #85359 is still ongoing, no conclusions or recommendations were made, lets not get ahead of ourselves with solutions like this. |
@nashif , I see, I move this PR to draft. and the issues I found with this PR are real issue, if you look at my fixes, many coding issues and dependency issue found. |
add minimal as tag for platforms Signed-off-by: Hake Huang <[email protected]>
for soc only fls_common.h need to be include, and port need depends on usage fixes: zephyrproject-rtos#85923 Signed-off-by: Hake Huang <[email protected]>
the define in wrong sequence fixes: 85924 Signed-off-by: Hake Huang <[email protected]>
include port fsl_port.h when needed fixes: zephyrproject-rtos#85923 Signed-off-by: Hake Huang <[email protected]>
hakehuang
force-pushed
the
refactor_minial_config
branch
from
e8efe36 to
d18ef5b
Compare
add CONFIG_SHELL=n as some defconf enable it Signed-off-by: Hake Huang <[email protected]>
remove platform_allow, extend integration_platform, and try to use feature tag to extend support for platforms