Fix an issue on RT1180 where TRDC permissions failed to be obtained #85545

lucien-nxp · 2025-02-11T03:41:26Z

soc: nxp: imxrt: imxrt118x: change trdc permission getting strategy
When TRDC permission fails to be obtained, it does not recycle to access ELE core to prevent blocking problems. The current practice only generates a log warning alarm.

butok · 2025-02-11T08:33:14Z

soc/nxp/imxrt/imxrt118x/soc.c

 #if defined(CONFIG_SOC_MIMXRT1189_CM33)
 		/* Release TRDC A to CM33 core */
 		sts = ELE_BaseAPI_ReleaseRDC(MU_RT_S3MUA, ELE_TRDC_AON_ID, ELE_CORE_CM33_ID);
 #elif defined(CONFIG_SOC_MIMXRT1189_CM7)
 		/* Release TRDC A to CM7 core */
 		sts = ELE_BaseAPI_ReleaseRDC(MU_RT_S3MUA, ELE_TRDC_AON_ID, ELE_CORE_CM7_ID);
 #endif
-	} while (ELE_IS_FAILED(sts));
+	if (sts != kStatus_Success) {
+		LOG_ERR("error: TRDC A permission get failed.");


As it reports false errors,
a Warning (not Error) can be a compromise.
We do not want stress users by "False" error messages.

Agreed. I have modified to warning log. Thank you.

mmahadevan108 · 2025-02-11T13:35:50Z

soc/nxp/imxrt/imxrt118x/soc.c

@@ -528,27 +531,27 @@ static ALWAYS_INLINE void trdc_enable_all_access(void)
 		sts = ELE_BaseAPI_GetFwStatus(MU_RT_S3MUA, &ele_fw_sts);
 	} while (sts != kStatus_Success);

-	do {
 #if defined(CONFIG_SOC_MIMXRT1189_CM33)
 		/* Release TRDC A to CM33 core */


Please fix the code indentation as the enclosing while loop has been removed.

Thank you. Fixed.

mmahadevan108 · 2025-02-11T13:46:07Z

soc/nxp/imxrt/imxrt118x/soc.c

@@ -528,27 +531,27 @@ static ALWAYS_INLINE void trdc_enable_all_access(void)
 		sts = ELE_BaseAPI_GetFwStatus(MU_RT_S3MUA, &ele_fw_sts);
 	} while (sts != kStatus_Success);


What about this while loop? Also line 524 should be fixed to use a tab instead of spaces.

This while loop don't need to be removed because the correct process need to get FW status firstly, and FW status getting won't block the CPU generally.

524 line have been used tab. Thank you.

mmahadevan108 · 2025-02-11T14:01:44Z

soc/nxp/imxrt/imxrt118x/soc.c

 #if defined(CONFIG_SOC_MIMXRT1189_CM33)
 		/* Release TRDC A to CM33 core */
 		sts = ELE_BaseAPI_ReleaseRDC(MU_RT_S3MUA, ELE_TRDC_AON_ID, ELE_CORE_CM33_ID);
 #elif defined(CONFIG_SOC_MIMXRT1189_CM7)
 		/* Release TRDC A to CM7 core */
 		sts = ELE_BaseAPI_ReleaseRDC(MU_RT_S3MUA, ELE_TRDC_AON_ID, ELE_CORE_CM7_ID);
 #endif
-	} while (ELE_IS_FAILED(sts));
+	if (sts != kStatus_Success) {
+		LOG_WRN("warning: TRDC A permission get failed.");


Please change to TRDC AON.

mmahadevan108 · 2025-02-11T14:02:07Z

soc/nxp/imxrt/imxrt118x/soc.c

-	} while (ELE_IS_FAILED(sts));
-
+	if (sts != kStatus_Success) {
+		LOG_WRN("warning: TRDC W permission get failed.");


Please change to TRDC Wakeup

What are the implications if the Release TRDC fails? This should be mentioned in the warning message.

Fixed. I added information in the warning log.

When TRDC permission fails to be obtained, it does not recycle to access ELE core to prevent blocking problems. The current practice only generates a log warning alarm. Signed-off-by: Lucien Zhao <[email protected]>

butok · 2025-02-13T09:53:18Z

Hi @lucien-nxp

After this commit, @tomi-font has reported error on Zephyr CI Discord: https://discordapp.com/channels/720317445772017664/1014241011989487716/1339527153347330110
job: https://github.com/zephyrproject-rtos/zephyr/actions/runs/13303120524/job/37148350472 :
west build -p -b mimxrt1180_evk/mimxrt1189/cm33 samples/net/dsa -T sample.net.dsa
It is a linker error:
../zephyr/soc/nxp/imxrt/imxrt118x/soc.c:624: undefined reference to log_dynamic_soc'`
Could you look it.

Other common samples are fine, so most probably this is a configuration issue (in a worst case to remove the soc logs).

kartben · 2025-02-13T10:06:01Z

@lucien-nxp I confirm this is breaking CI in main https://github.com/zephyrproject-rtos/zephyr/actions/runs/13303203198/job/37148374503
Will line up a revert PR but let us know ASAP if you are working on a fix. cc @fabiobaltieri

kartben · 2025-02-13T11:47:48Z

FWIW the revert PR is here: #85720

lucien-nxp · 2025-02-14T03:12:57Z

Hi @lucien-nxp

After this commit, @tomi-font has reported error on Zephyr CI Discord: https://discordapp.com/channels/720317445772017664/1014241011989487716/1339527153347330110 job: https://github.com/zephyrproject-rtos/zephyr/actions/runs/13303120524/job/37148350472 : west build -p -b mimxrt1180_evk/mimxrt1189/cm33 samples/net/dsa -T sample.net.dsa It is a linker error: ../zephyr/soc/nxp/imxrt/imxrt118x/soc.c:624: undefined reference to log_dynamic_soc'` Could you look it.

Other common samples are fine, so most probably this is a configuration issue (in a worst case to remove the soc logs).

Mahesh help me resolve the building issue and create #85741. Thank you for you reminding.

lucien-nxp changed the title ~~Fixed an issue on RT1180 where TRDC permissions failed to be obtained~~ Fix an issue on RT1180 where TRDC permissions failed to be obtained Feb 11, 2025

zephyrbot added the platform: NXP NXP label Feb 11, 2025

zephyrbot requested review from butok, decsny, DerekSnell, dleach02, EmilioCBen and mmahadevan108 February 11, 2025 03:41

zephyrbot assigned dleach02 and mmahadevan108 Feb 11, 2025

butok previously approved these changes Feb 11, 2025

View reviewed changes

lucien-nxp dismissed butok’s stale review via a2ecdfc February 11, 2025 08:25

lucien-nxp force-pushed the feature/change_trdc_premission_getting_strategy branch from 3a7e740 to a2ecdfc Compare February 11, 2025 08:25

butok reviewed Feb 11, 2025

View reviewed changes

lucien-nxp force-pushed the feature/change_trdc_premission_getting_strategy branch from a2ecdfc to 49a2b3a Compare February 11, 2025 08:48

butok previously approved these changes Feb 11, 2025

View reviewed changes

butok mentioned this pull request Feb 11, 2025

soc: imxrt118x: fix initialization stuck #84287

Closed

mmahadevan108 reviewed Feb 11, 2025

View reviewed changes

soc: nxp: imxrt: imxrt118x: change trdc permission getting strategy

9cacfc3

When TRDC permission fails to be obtained, it does not recycle to access ELE core to prevent blocking problems. The current practice only generates a log warning alarm. Signed-off-by: Lucien Zhao <[email protected]>

lucien-nxp dismissed butok’s stale review via 9cacfc3 February 12, 2025 03:24

lucien-nxp force-pushed the feature/change_trdc_premission_getting_strategy branch from 49a2b3a to 9cacfc3 Compare February 12, 2025 03:24

lucien-nxp requested a review from mmahadevan108 February 12, 2025 03:27

mmahadevan108 approved these changes Feb 12, 2025

View reviewed changes

mmahadevan108 requested a review from butok February 12, 2025 22:13

butok approved these changes Feb 13, 2025

View reviewed changes

kartben merged commit e3538a3 into zephyrproject-rtos:main Feb 13, 2025
22 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix an issue on RT1180 where TRDC permissions failed to be obtained #85545

Fix an issue on RT1180 where TRDC permissions failed to be obtained #85545

lucien-nxp commented Feb 11, 2025

butok Feb 11, 2025

lucien-nxp Feb 11, 2025

mmahadevan108 Feb 11, 2025

lucien-nxp Feb 12, 2025

mmahadevan108 Feb 11, 2025

lucien-nxp Feb 12, 2025

mmahadevan108 Feb 11, 2025

lucien-nxp Feb 12, 2025

mmahadevan108 Feb 11, 2025

mmahadevan108 Feb 11, 2025

lucien-nxp Feb 12, 2025

butok commented Feb 13, 2025

kartben commented Feb 13, 2025

kartben commented Feb 13, 2025

lucien-nxp commented Feb 14, 2025

		@@ -528,27 +531,27 @@ static ALWAYS_INLINE void trdc_enable_all_access(void)
		sts = ELE_BaseAPI_GetFwStatus(MU_RT_S3MUA, &ele_fw_sts);
		} while (sts != kStatus_Success);

Fix an issue on RT1180 where TRDC permissions failed to be obtained #85545

Fix an issue on RT1180 where TRDC permissions failed to be obtained #85545

Conversation

lucien-nxp commented Feb 11, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

butok commented Feb 13, 2025

kartben commented Feb 13, 2025

kartben commented Feb 13, 2025

lucien-nxp commented Feb 14, 2025