Added RangeInclusive Span support. #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ippy inclusive suggestion for single character ranges which is fairly common.
|
This doesn't seem correct implementation-wise: Shouldn't the end of the span be one past the inclusive end? |
|
No? We just want the start and the end of the range. How that is handled internally by the type is irrelevant to us. The big difference here is that we want to support: ("file_name.py", 0..5) as well as ("file_name.py", 0..=4) The first uses Range, the second uses RangeInclusive, but they should both return the same values. |
|
Apparently, I am not a smart man. Just tested it and yup. You were right. had to add the +1 there. =P |
|
Anything else needed for this? |
|
I think this is fine. Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should remove the annoying clippy inclusive range suggestion for single character ranges which is fairly common.
This is a relatively minor change of two impl's which mirror the Range versions fairly closely.