-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated icons and copyright year #175
Conversation
Updated PreferencesPane icon
Updated application icon
Updated copyright year in Info.plist
Thanks a lot! I will check it out tomorrow. For the prefpane, the issue happens since it need to refresh the status frequent. And so far I didn't find a good example or tutorial. One possible solution is, to disable status update, if something changed, you need to close the prefpane window completely and reopen that. What do you think about it? |
Compared to a crashing pane, I prefer to refresh to be honest. |
Just downloaded the icns... I suppose there's copyright issue with that. |
OK @zhen-zen I understand totally. Allow me to create some custom icons then? |
I was looking for "gears" icon (denoting "Settings" as usual) and came across the car's gear, so instead of the numbers I thought of adding a red dot (over the numbers) that makes people think of the Lenovo red, what do you think? I didn't add anything on the red dot, on purpose... Would you like this instead, @zhen-zen ? |
That's a good metaphor. Although this driver is not only for Thinkpad series, I agree with that. |
Thanks, not really related to ThinkPad but all Lenovo due to the red colour 😄 (as Lenovo logo switched to red...) |
Hi @zhen-zen I took the liberty of updating the icons for the PreferencePane and the menu icons, including the respective Info.plist files. Also, I updated for you the Copyright years.
The new release as you are aware, still has the bug that I reported some time ago #159 and as I have friends at work that know Xcode, I will ask them if they know how to smoothly quit a Preference Pane to avoid this issue in the next release, hopefully...
Hope you like my work and approve this request! Cheers
P.S. Obviously these couple of changes were already tested on my IdeaPad 😄