x86_64: implement error set and enum safety #22876
Open
+12,077
−6,311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobly0
force-pushed
the
x86_64-rewrite
branch
2 times, most recently
from
7c4f115 to
e42376a
Compare
7 tasks
jacobly0
force-pushed
the
x86_64-rewrite
branch
3 times, most recently
from
3c7e964 to
cb655cf
Compare
|
Might want to enable the corresponding tests, which live in test/cases/safety/* |
jacobly0
force-pushed
the
x86_64-rewrite
branch
5 times, most recently
from
750522d to
847a4fd
Compare
This is all of the expected 0.14.0 progress on ziglang#21530, which can now be postponed once this commit is merged. This required rewriting the (un)wrap operations since the original implementations were extremely buggy. Also adds an easy way to retrigger Sema OPV bugs so that I don't have to keep updating ziglang#22419 all the time.
I observed a stack overflow during x86_64 CodeGen in a debug compiler compiled by the llvm backend. This happens while compiling `main.buildOutputType` due to the Air being nested almost 500 levels.
jacobly0
force-pushed
the
x86_64-rewrite
branch
from
847a4fd to
06300c5
Compare
jacobly0
force-pushed
the
x86_64-rewrite
branch
from
06300c5 to
dcc9fe3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is all of the expected 0.14.0 progress on #21530, which can now be postponed once this commit is merged.
This required rewriting the (un)wrap operations since the original implementations were extremely buggy.
Also adds an easy way to retrigger Sema OPV bugs so that I don't have to keep updating #22419 all the time.