Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧹 Rename from Room to Section and Furniture to Gizmo #1472

Open
6 of 9 tasks
Tracked by #1155
zspencer opened this issue May 18, 2023 · 6 comments
Open
6 of 9 tasks
Tracked by #1155

🧹 Rename from Room to Section and Furniture to Gizmo #1472

zspencer opened this issue May 18, 2023 · 6 comments
Assignees
Labels
🌸 Polish Improves the UX! 🧹 refactor Includes non-behavioral changes

Comments

@zspencer
Copy link
Member

zspencer commented May 18, 2023

During one of our demos with Piikup, we noticed there was a degree of struggle with the "Room" and "Furniture" nomenclature. @anaulin brought that to the ensembles, and we talked a bit about shifting away from "Room" (which is a holdover from when we were focusing on the Videobridge Furniture.

@zspencer zspencer mentioned this issue May 18, 2023
8 tasks
@zspencer zspencer changed the title Explore renaming Room to Section Rooms: Explore renaming from Room to Section May 18, 2023
@zspencer zspencer added this to the 1.0 - Andromeda milestone May 18, 2023
@zspencer zspencer added 🌸 Polish Improves the UX! 🧹 refactor Includes non-behavioral changes labels May 18, 2023
@zspencer zspencer changed the title Rooms: Explore renaming from Room to Section 🧹 Rooms: Explore renaming from Room to Section May 18, 2023
KellyAH added a commit that referenced this issue May 18, 2023
Replace "Room" and "Rooms" in the views and
locales files with Section and Sections

Co-authored-by: Zee Spencer <[email protected]>
Co-authored-by: Ana <[email protected]>
Co-authored-by: Dalton Pruitt <[email protected]>
@zspencer zspencer changed the title 🧹 Rooms: Explore renaming from Room to Section 🧹 Rooms: Explore renaming from Furniture to Gizmo Jun 15, 2023
@zspencer zspencer changed the title 🧹 Rooms: Explore renaming from Furniture to Gizmo 🧹 Rename from Room to Section and Furniture to Gizmo Jun 15, 2023
@zspencer
Copy link
Member Author

I've gone ahead and updated the issue title for all the Furniture and renamed the Furniture label to Gizmo

@KellyAH KellyAH removed their assignment Jun 15, 2023
@KellyAH
Copy link
Contributor

KellyAH commented Jun 15, 2023

@zspencer @anaulin Are we happy with the renames of "Section" "Gizmo"/"Gizmos"?

Should I proceed with the remaining refactor tasks to Update Docs and Rename the Models and Tables to match the rename? Or wait longer till we get more feedback/info?

@KellyAH KellyAH self-assigned this Jun 15, 2023
@anaulin
Copy link
Member

anaulin commented Jun 15, 2023

I'd wait a little longer on the models and tables (like, a few months at least?). It would be nice to drop a note in the docs about how we are calling them differently in the UI.

@zspencer
Copy link
Member Author

Agreed, for now I think we should let the old names ride at the application layer; and perhaps in September throw the switch.

@KellyAH
Copy link
Contributor

KellyAH commented Jun 17, 2023

It would be nice to drop a note in the docs about how we are calling them differently in the UI.

These docs still mentions Room/Rooms:

Did you want me to replace any Room text in those docs with Section? Or slap 1 line of text at the top mentioning that Room has been renamed to Section?

A LOT of docs mention Furniture:

Did you want me to replace any Furniture text in those docs with Gizmo? Or slap 1 line of text at the top of each doc mentioning that Furniture has been renamed to Gizmo?

@anaulin
Copy link
Member

anaulin commented Jun 17, 2023

I'd say slap the one line for now. We might rename it back or again or who knows... 🤷🏼‍♀️

@KellyAH KellyAH removed their assignment Jun 20, 2023
zspencer added a commit that referenced this issue Jun 25, 2023
zspencer added a commit that referenced this issue Jun 25, 2023
zspencer added a commit that referenced this issue Jun 26, 2023
zspencer added a commit that referenced this issue Jun 26, 2023
zspencer added a commit that referenced this issue Jun 28, 2023
zspencer added a commit that referenced this issue Jun 28, 2023
* `Gizmo`: Access a `Room`'s Gizmos via `.gizmos`

- #1472
- #709
- #1155

It should be possible to rename the `Furniture` class (and it's related `Controller`, `Policy`, and `Views`) next!
zspencer added a commit to zinc-collective/tobias that referenced this issue Feb 13, 2024
- #1
- zinc-collective#709

- For a #9 to leverage
  the behavior we described, we need a way to put tobias on the web.
  zinc-collective#709 are the equivalent
  of an "App" in the Convene world.

- Note: `Gizmo` and `Furniture` are equivalent. We probably should
  finish zinc-collective#1472

- The migration change makes sure that ahttps://github.com//issues/4
  is connected to #1
zspencer added a commit to zinc-collective/tobias that referenced this issue Feb 13, 2024
- #1
- zinc-collective#709

- For a #9 to leverage
  the behavior we described, we need a way to put tobias on the web.
  zinc-collective#709 are the equivalent
  of an "App" in the Convene world.

- Note: `Gizmo` and `Furniture` are equivalent. We probably should
  finish zinc-collective#1472

- The migration change makes sure that ahttps://github.com//issues/4
  is connected to #1
zspencer added a commit to zinc-collective/tobias that referenced this issue Feb 13, 2024
- #1
- zinc-collective#709

- For a #9 to leverage
  the behavior we described, we need a way to put tobias on the web.
  zinc-collective#709 are the equivalent
  of an "App" in the Convene world.

- Note: `Gizmo` and `Furniture` are equivalent. We probably should
  finish zinc-collective#1472

- The migration change makes sure that ahttps://github.com//issues/4
  is connected to #1
zspencer added a commit to zinc-collective/tobias that referenced this issue Feb 27, 2024
- #1
- zinc-collective#709

- For a #9 to leverage
  the behavior we described, we need a way to put tobias on the web.
  zinc-collective#709 are the equivalent
  of an "App" in the Convene world.

- Note: `Gizmo` and `Furniture` are equivalent. We probably should
  finish zinc-collective#1472

- The migration change makes sure that ahttps://github.com//issues/4
  is connected to #1
zspencer added a commit to zinc-collective/tobias that referenced this issue Feb 27, 2024
- #1
- zinc-collective#709

- For a #9 to leverage
  the behavior we described, we need a way to put tobias on the web.
  zinc-collective#709 are the equivalent
  of an "App" in the Convene world.

- Note: `Gizmo` and `Furniture` are equivalent. We probably should
  finish zinc-collective#1472

- The migration change makes sure that ahttps://github.com//issues/4
  is connected to #1
zspencer added a commit to zinc-collective/tobias that referenced this issue Mar 25, 2024
- #1
- zinc-collective#709

- For a #9 to leverage
  the behavior we described, we need a way to put tobias on the web.
  zinc-collective#709 are the equivalent
  of an "App" in the Convene world.

- Note: `Gizmo` and `Furniture` are equivalent. We probably should
  finish zinc-collective#1472

- The migration change makes sure that ahttps://github.com//issues/4
  is connected to #1
zspencer added a commit to zinc-collective/tobias that referenced this issue Mar 25, 2024
- #1
- zinc-collective#709

- For a #9 to leverage
  the behavior we described, we need a way to put tobias on the web.
  zinc-collective#709 are the equivalent
  of an "App" in the Convene world.

- Note: `Gizmo` and `Furniture` are equivalent. We probably should
  finish zinc-collective#1472

- The migration change makes sure that ahttps://github.com//issues/4
  is connected to #1
zspencer added a commit to zinc-collective/tobias that referenced this issue Mar 25, 2024
- #1
- zinc-collective#709

- For a #9 to leverage
  the behavior we described, we need a way to put tobias on the web.
  zinc-collective#709 are the equivalent
  of an "App" in the Convene world.

- Note: `Gizmo` and `Furniture` are equivalent. We probably should
  finish zinc-collective#1472

- The migration change makes sure that ahttps://github.com//issues/4
  is connected to #1
@rosschapman rosschapman self-assigned this Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌸 Polish Improves the UX! 🧹 refactor Includes non-behavioral changes
Projects
None yet
Development

No branches or pull requests

4 participants