Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⛰️✨ Sections #1155

Closed
7 of 8 tasks
zspencer opened this issue Mar 2, 2023 · 1 comment
Closed
7 of 8 tasks

⛰️✨ Sections #1155

zspencer opened this issue Mar 2, 2023 · 1 comment
Labels
⛰️ epic Work we expect will take multiple patches to complete ✨ feature Reduces Client's Burden or Grants them Benefits 🥔 Satisfices It's good enough to use, but not particularly great
Milestone
1.1 - B???

Comments

@zspencer
Copy link
Member

zspencer commented Mar 2, 2023 •
edited
Loading

Use Cases

Data Model

Design

Bugs
@zspencer zspencer added the ⛰️ epic Work we expect will take multiple patches to complete label Mar 2, 2023
@zspencer zspencer added this to the 1.0 - Andromeda milestone Mar 2, 2023
@zspencer zspencer changed the title Rooms 🥔 Rooms Mar 2, 2023
zspencer added a commit that referenced this issue Mar 2, 2023
@zspencer
Room: Don't always provide a current_room
d923849 
- #926
- #1155

There are many pages that are not in a `room`, and the `policy_scope` of
`current_room` could result in a false safety.

That said, we probably should *also* be writing `request` specs to
confirm that folks get 404 on endpoints outside of their scope...
@zspencer zspencer mentioned this issue Mar 2, 2023
Closed
zspencer added a commit that referenced this issue Mar 4, 2023
@zspencer
🧹 Rooms: Get rid of locked/unlocked Rooms
4fef839 
- #1155

It's not really serving us, and is a hold-over from when Convene was
more video-forward.
zspencer added a commit that referenced this issue Mar 4, 2023
@zspencer
🧹 Rooms: Get rid of locked/unlocked Rooms
d3f6248 
- #1155

It's not really serving us, and is a hold-over from when Convene was
more video-forward.
@zspencer zspencer mentioned this issue Mar 4, 2023
Merged
zspencer added a commit that referenced this issue Mar 4, 2023
@zspencer
🧹 Rooms: Get rid of locked/unlocked Rooms
7d4613f 
- #1155

It's not really serving us, and is a hold-over from when Convene was
more video-forward.
zspencer added a commit that referenced this issue Mar 4, 2023
@zspencer
🧹 Rooms: Get rid of locked/unlocked Rooms
26c1db3 
- #1155

It's not really serving us, and is a hold-over from when Convene was
more video-forward.
zspencer added a commit that referenced this issue Mar 4, 2023
@zspencer
🧹 Rooms: Get rid of locked/unlocked Rooms
f3ee93c 
- #1155

It's not really serving us, and is a hold-over from when Convene was
more video-forward.
zspencer added a commit that referenced this issue Mar 4, 2023
@zspencer
🧹 Rooms: Get rid of locked/unlocked Rooms
96492d2 
- #1155

It's not really serving us, and is a hold-over from when Convene was
more video-forward.
zspencer added a commit that referenced this issue Mar 4, 2023
@zspencer
🧹 Rooms: Get rid of locked/unlocked Rooms
5d49843 
- #1155

It's not really serving us, and is a hold-over from when Convene was
more video-forward.
zspencer added a commit that referenced this issue Mar 4, 2023
@zspencer
🧹 Rooms: Get rid of locked/unlocked Rooms
c819266 
- #1155
- #1151

It's not really serving us, and is a hold-over from when Convene was
more video-forward.

Instead, we may want to create a `Furniture` that can "bounce" people
from a `Room` unless they know the secret code / are `Member`s of the
`Space` or in an appropriate `Group`.
zspencer added a commit that referenced this issue Mar 4, 2023
@zspencer
🧹 Rooms: Get rid of locked/unlocked/internal Rooms in favor o…
36705bf 
…f `public`/`internal` (#1183)

- #1155
- #1151

It's not really serving us, and is a hold-over from when Convene was
more video-forward.

Instead, we may want to create a `Furniture` that can "bounce" people
from a `Room` unless they know the secret code / are `Member`s of the
`Space` or in an appropriate `Group`.
zspencer added a commit that referenced this issue Mar 31, 2023
@zspencer
🧹 Space, Furniture, and Room: Fill in missing assocations
0a4e702 
- #832
- #1155
- #1154
- #709

As I was working to onboard Piikup, I discovered I couldn't really write
an easy script to merge into a space since I didn't have the
associations together.

Now they're super tight! Yyyaaaaaaah!
@zspencer zspencer mentioned this issue Mar 31, 2023
Merged
zspencer added a commit that referenced this issue Apr 2, 2023
@zspencer
🧹 Space, Furniture, and Room: Fill in missing associations (#1285)
77a01bf 
- #832
- #1155
- #1154
- #709

As I was working to onboard Piikup, I discovered I couldn't really write
an easy script to merge into a space since I didn't have the
associations together.

Now they're super tight! Yyyaaaaaaah!
@zspencer zspencer mentioned this issue Apr 3, 2023
Merged
@zspencer zspencer mentioned this issue May 18, 2023
Open
9 tasks
@zspencer zspencer added the ✨ feature Reduces Client's Burden or Grants them Benefits label May 18, 2023
@zspencer zspencer changed the title 🥔 Rooms 🥔⛰️✨ Rooms May 18, 2023
This was referenced May 18, 2023
Closed
Closed
@anaulin anaulin mentioned this issue May 25, 2023
Merged
@zspencer zspencer added the 🥔 Satisfices It's good enough to use, but not particularly great label Jun 15, 2023
@zspencer zspencer changed the title 🥔⛰️✨ Rooms 🥔⛰️✨ Sections Jun 15, 2023
@zspencer zspencer mentioned this issue Jun 15, 2023
Closed
3 tasks
zspencer added a commit that referenced this issue Oct 5, 2023
@zspencer
🧹 Section: Drop the publicity_level column, since it is dead (#1870)
4b6660b 
- #1155
rosschapman pushed a commit that referenced this issue Oct 23, 2023
@zspencer @rosschapman
Section: Remove Listed concept; since it's confusing
2b26f70 
- #1155

At some point, it would make sense for us to make a Gizmo for linking to
different places (even ones outside of the Space!) and replacing the
Section Navigation bar with that.

But in the meantime, the `Listed` vs `Unlisted` dichotomy isn't really
serving us, and is getting in the way a little bit.
rosschapman pushed a commit that referenced this issue Oct 23, 2023
@zspencer @rosschapman
Section: Drop the publicity_level column, since it is dead
353a656 
- #1155
@zspencer zspencer mentioned this issue Nov 8, 2023
Closed
2 tasks
This was referenced Nov 23, 2023
Closed
Open
@zspencer zspencer mentioned this issue Dec 4, 2023
Open
10 tasks
zspencer added a commit that referenced this issue Dec 4, 2023
@zspencer
🧹 Section: Remove Navigation in favor of SectionNavigation Gizmo
a035c67 
- #1155
- #1988

Now that we have a Gizmo for navigating between Sections, we don't want
to keep it everywhere.
@zspencer zspencer mentioned this issue Dec 4, 2023
Merged
zspencer added a commit that referenced this issue Dec 5, 2023
@zspencer
🧹 Section: Remove Navigation in favor of SectionNavigation Gizmo (#…
4a2af3b 
…1989)

* 🧹 `Section`: Remove Navigation in favor of `SectionNavigation` Gizmo

- #1155
- #1988

Now that we have a Gizmo for navigating between Sections, we don't want
to keep it everywhere.

* `Sections`: Eliminate feature tests presuming navigation between rooms

Now that we're using the gizmo, it doesn't make sense to have end-to-end
tests that presume every Section will include functioality to navigate
between Sections.

This also gets rid of all the unused step definitions.

* Add system spec for SectionNavigation

* 🧹 Delete driver code related to `Section Navigation`
@zspencer zspencer mentioned this issue Dec 11, 2023
Closed
This was referenced Dec 16, 2023
Open
Open
zspencer added a commit that referenced this issue Dec 21, 2023
@zspencer
Section: Allow description to be set for SEO
6fe0467 
- #1155

- Meta description tags are useful for SEO; and maybe even useful for
  #1988

- I would love if we allowed `Section#title` to be set as well
@zspencer zspencer mentioned this issue Dec 21, 2023
Merged
zspencer added a commit that referenced this issue Dec 21, 2023
@zspencer
Section: Allow description to be set for SEO
65222a6 
- #1155

- Meta description tags are useful for SEO; and maybe even useful for
  #1988

- I would love if we allowed `Section#title` to be set as well
zspencer added a commit that referenced this issue Dec 21, 2023
@zspencer
✨ Section: Allow description to be set for SEO (#2055)
9d31b6b 
- #1155

- Meta description tags are useful for SEO; and maybe even useful for
  #1988

- I would love if we allowed `Section#title` to be set as well
zspencer added a commit that referenced this issue Dec 21, 2023
@zspencer
Section: Permit setting the #description
a887ef3 
- #1155

- I forgot this in #2055.
  Which probably means I should write a system spec.
@zspencer zspencer mentioned this issue Dec 21, 2023
Merged
anaulin pushed a commit that referenced this issue Dec 21, 2023
@zspencer
🐞🔨 Section: Permit setting the #description (#2058)
30d64fe 
* `Section`: Permit setting the `#description`

- #1155

- I forgot this in #2055.
  Which probably means I should write a system spec.

* Redirect ftw
zspencer added a commit that referenced this issue Dec 27, 2023
@zspencer
🧹 Sections: Fix failing spec
9c2e642 
#1155

Not really sure if I actually fixed it; but oh well; this is easier to
read IMO
@zspencer zspencer mentioned this issue Dec 27, 2023
Merged
zspencer added a commit that referenced this issue Dec 27, 2023
@zspencer
🧹 Sections: Fix failing spec (#2070)
9d4e664 
#1155

Not really sure if I actually fixed it; but oh well; this is easier to
read IMO
zspencer added a commit that referenced this issue Jan 4, 2024
@zspencer
🐛🔨 Section: Shorten Factory Generated Room#description
12ee29e 
- #1155
- #1988

Apparently, some of the Expanse Quotes are quite long; making them
[ill-suited for a 300 character limited
field](https://github.com/zinc-collective/convene/actions/runs/7403679313/job/20145303706?pr=2079).

This shortens those down so they don't explode.
@zspencer zspencer mentioned this issue Jan 4, 2024
Merged
zspencer added a commit that referenced this issue Jan 4, 2024
@zspencer
🐛🔨 Section: Shorten Factory Generated Room#description (#2081)
7fb1a11 
* 🐛🔨 `Section`: Shorten Factory Generated `Room#description`

- #1155
- #1988

Apparently, some of the Expanse Quotes are quite long; making them
[ill-suited for a 300 character limited
field](https://github.com/zinc-collective/convene/actions/runs/7403679313/job/20145303706?pr=2079).

This shortens those down so they don't explode.

* Demagistrate the Number
@zspencer zspencer changed the title 🥔⛰️✨ Sections ⛰️✨ Section Apr 11, 2024
@zspencer zspencer changed the title ⛰️✨ Section ⛰️✨ Sections Apr 11, 2024
@rosschapman
Copy link
Contributor

🧹 Relegated to cold storage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
⛰️ epic Work we expect will take multiple patches to complete ✨ feature Reduces Client's Burden or Grants them Benefits 🥔 Satisfices It's good enough to use, but not particularly great
Projects
None yet
Milestone
1.1 - B???
Development

No branches or pull requests
2 participants
@rosschapman @zspencer