Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🥔🗜️✨ Gizmo: SectionNavigation #1988

Open
2 of 10 tasks
Tracked by #709
zspencer opened this issue Dec 4, 2023 · 0 comments
Open
2 of 10 tasks
Tracked by #709

🥔🗜️✨ Gizmo: SectionNavigation #1988

zspencer opened this issue Dec 4, 2023 · 0 comments
Assignees
@rosschapman

Comments

@zspencer
Copy link
Member

zspencer commented Dec 4, 2023 •
edited
Loading

Use Cases
@zspencer zspencer mentioned this issue Dec 4, 2023
Closed
23 tasks
@zspencer zspencer changed the title Gizmo: SectionNavigation 🥔✨ Gizmo: SectionNavigation Dec 4, 2023
zspencer added a commit that referenced this issue Dec 4, 2023
@zspencer
🧹 Section: Remove Navigation in favor of SectionNavigation Gizmo
a035c67 
- #1155
- #1988

Now that we have a Gizmo for navigating between Sections, we don't want
to keep it everywhere.
@zspencer zspencer mentioned this issue Dec 4, 2023
Merged
zspencer added a commit that referenced this issue Dec 5, 2023
@zspencer
🧹 Section: Remove Navigation in favor of SectionNavigation Gizmo (#…
4a2af3b 
…1989)

* 🧹 `Section`: Remove Navigation in favor of `SectionNavigation` Gizmo

- #1155
- #1988

Now that we have a Gizmo for navigating between Sections, we don't want
to keep it everywhere.

* `Sections`: Eliminate feature tests presuming navigation between rooms

Now that we're using the gizmo, it doesn't make sense to have end-to-end
tests that presume every Section will include functioality to navigate
between Sections.

This also gets rid of all the unused step definitions.

* Add system spec for SectionNavigation

* 🧹 Delete driver code related to `Section Navigation`
This was referenced Dec 17, 2023
Open
Open
@zspencer zspencer changed the title 🥔✨ Gizmo: SectionNavigation 🥔🗜️✨ Gizmo: SectionNavigation Dec 19, 2023
zspencer added a commit that referenced this issue Dec 21, 2023
@zspencer
Section: Allow description to be set for SEO
6fe0467 
- #1155

- Meta description tags are useful for SEO; and maybe even useful for
  #1988

- I would love if we allowed `Section#title` to be set as well
@zspencer zspencer mentioned this issue Dec 21, 2023
Merged
zspencer added a commit that referenced this issue Dec 21, 2023
@zspencer
Section: Allow description to be set for SEO
65222a6 
- #1155

- Meta description tags are useful for SEO; and maybe even useful for
  #1988

- I would love if we allowed `Section#title` to be set as well
zspencer added a commit that referenced this issue Dec 21, 2023
@zspencer
✨ Section: Allow description to be set for SEO (#2055)
9d31b6b 
- #1155

- Meta description tags are useful for SEO; and maybe even useful for
  #1988

- I would love if we allowed `Section#title` to be set as well
@zspencer zspencer mentioned this issue Dec 27, 2023
Merged
3 tasks
zspencer added a commit that referenced this issue Dec 28, 2023
@zspencer
🥔✨ SectionNavigation: Include Section#description in SectionLink (#…
12063b0 
…2057)

* `SectionNavigation`: Include `Section#description` in SectionLink

- #1988
zspencer added a commit that referenced this issue Jan 4, 2024
@zspencer
🐛🔨 Section: Shorten Factory Generated Room#description
12ee29e 
- #1155
- #1988

Apparently, some of the Expanse Quotes are quite long; making them
[ill-suited for a 300 character limited
field](https://github.com/zinc-collective/convene/actions/runs/7403679313/job/20145303706?pr=2079).

This shortens those down so they don't explode.
@zspencer zspencer mentioned this issue Jan 4, 2024
Merged
zspencer added a commit that referenced this issue Jan 4, 2024
@zspencer
🐛🔨 Section: Shorten Factory Generated Room#description (#2081)
7fb1a11 
* 🐛🔨 `Section`: Shorten Factory Generated `Room#description`

- #1155
- #1988

Apparently, some of the Expanse Quotes are quite long; making them
[ill-suited for a 300 character limited
field](https://github.com/zinc-collective/convene/actions/runs/7403679313/job/20145303706?pr=2079).

This shortens those down so they don't explode.

* Demagistrate the Number
@zspencer zspencer mentioned this issue Feb 8, 2024
Merged
@rosschapman rosschapman mentioned this issue Feb 29, 2024
Open
This was referenced Mar 7, 2024
Merged
Merged
Merged
Merged
This was referenced Apr 4, 2024
Merged
Merged
@rosschapman rosschapman self-assigned this Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rosschapman rosschapman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rosschapman @zspencer