🐛🔨 Section: Shorten Factory Generated Room#description
#2081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- #1155 - #1988 Apparently, some of the Expanse Quotes are quite long; making them [ill-suited for a 300 character limited field](https://github.com/zinc-collective/convene/actions/runs/7403679313/job/20145303706?pr=2079). This shortens those down so they don't explode.
rosschapman
approved these changes
Jan 4, 2024
spec/factories/room.rb
Outdated
| @@ -16,7 +16,7 @@ | |||
| end | |||
|
|
|||
| trait :with_description do | |||
| description { Faker::TvShows::TheExpanse.quote } | |||
| description { Faker::TvShows::TheExpanse.quote.truncate(300) } | |||
There was a problem hiding this comment.
Could this value be stored in a constant, like Room::DescriptionLength? It feels magical here.
There was a problem hiding this comment.
I could go with Room::MAXIMUM_DESCRIPTION_LENGTH.
There was a problem hiding this comment.
I went with DESCRIPTION_MAX_LENGTH so the starting letter for the constant matches the attribute it is used to validate.
zspencer
deleted the
section_navigation/prevent-flakiness-for-long-descriptions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sections#1155Gizmo:SectionNavigation#1988Apparently, some of the Expanse Quotes are quite long; making them ill-suited for a 300 character limited
field.
This shortens those down so they don't explode.