Marketplace: save stripe api key #1009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bug: saved api key fails to display in Marketplace Config page Co-authored-by: Zee Spencer <[email protected]> Co-authored-by: Ana <[email protected]> Co-authored-by: Naomi Quinones <[email protected]>
anaulin
reviewed
Dec 22, 2022
anaulin
reviewed
Dec 22, 2022
Co-authored-by: Ana Ulin <[email protected]>
zspencer
reviewed
Dec 23, 2022
zspencer
approved these changes
Dec 23, 2022
| @@ -5,6 +5,10 @@ class MarketplacePolicy < ApplicationPolicy | |||
| def show? | |||
| true | |||
| end | |||
|
|
|||
| def update? | |||
| true | |||
There was a problem hiding this comment.
Maybe this logic should be thought through a bit before merge :D
* Marketplace: MarketplacesController#edit Spec Just a basic "get the route, confirm it renders a template successfully for authenticated user and is a 404 when not" * Marketplace: Unit tests MarketplacePolicy#update?
We had been doing our smoke-testing with authenticated users, not guests; and then Zee broke everything by not logging in and discovering that we hadn't actually handled the Guest case well. This tests the `Marketplace::CheckoutPolicy`, as well as sprouts some Factories for creating `:marketplace_checkout`s more conveniently. co-authored-by: Ana Ulin <[email protected]> co-authored-by: Dalton <[email protected]> co-authored-by: Kelly Hong <[email protected]>
- Adds Breadcrumbs - Places Configure Products underneath the `marketplace/edit` view co-authored-by: Ana Ulin <[email protected]> co-authored-by: Dalton <[email protected]> co-authored-by: Kelly Hong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: #831
Added logic for saving stripe api key on Marketplace.
Integrating with stripe via saving the stripe api key was more difficult than we thought. 😞
Co-authored-by: Zee Spencer [email protected]
Co-authored-by: Ana [email protected]
Co-authored-by: Naomi Quinones [email protected]
TODO: