Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Marketplace: Accept Payments #1031

Merged
merged 18 commits into from
Jan 19, 2023
Merged

Marketplace: Accept Payments #1031

merged 18 commits into from
Jan 19, 2023

Conversation

zspencer
Copy link
Member

@zspencer zspencer commented Jan 5, 2023 •
edited
Loading

#831

  • Accept Payments via Stripe Checkout
    • Happy Path
      • Prevent change to CartProducts Quantity when Cart is Checked Out
      • Prevent destruction of CartProducts when Cart is Checked Out
      • (Zee's note: Perhaps this is best done at the Policy level, so Sellers/Distributors may update + destroy CartProduct(s) after Checkout but Shoppers cannot?
      • make sure that the current cart is correctly reset after a checkout
    • Sad Path
  • Tidy
    • Request Specs
    • Model Specs
    • Pull Stripe API bits out of Marketplace::CheckoutsController and into Marketplace::Checkout?

Co-authored-by: Ana [email protected]
Co-authored-by: Dalton [email protected]
Co-authored-by: Kelly Hong [email protected]

@zspencer zspencer force-pushed the marketplace/begin-processing-payment branch 2 times, most recently from 18dfe1e to 01cf97e Compare January 8, 2023 20:11
@zspencer zspencer marked this pull request as draft January 8, 2023 20:51
@anaulin anaulin force-pushed the marketplace/begin-processing-payment branch from 67c9852 to 8cd9268 Compare January 12, 2023 03:11
zspencer and others added 7 commits January 15, 2023 13:59
@zspencer @anaulin
Marketplace: Start sketching out docs for how we Checkout
1bc996d 
Co-authored-by: Ana <[email protected]>
Co-authored-by: Dalton <[email protected]>
Co-authored-by: Kelly Hong <[email protected]>
@zspencer @daltonrpruitt @anaulin
Stripe: Install Stripe Gem
8c62d1d 
Co-authored-by: Dalton <[email protected]>
@zspencer @daltonrpruitt @anaulin
Marketplace: Buyer checks-out with Stripe Checkout!
ae826c3 
FUCK YEAAHHHHHHH

Co-authored-by: Dalton <[email protected]>
@zspencer @daltonrpruitt
@naomiquinones @anaulin
Marketplace: Tidy up generation of Stripe session
85ea545 
Co-authored-by: Dalton <[email protected]>
Co-authored-by: Naomi Quinones <[email protected]>
@zspencer @daltonrpruitt
@naomiquinones @anaulin
Marketplace; Turbo does not like the URL used for Stripe Checkout
b784ce3 
For whatever reason, it is truncating the urls; and rather than fucking
around trying to figure out how to make turbo play nicely, just disable;
since we know we will need to redraw the entire DOM anyway, since we are
redirecting to a Stripe Checkout page.

Co-authored-by: Dalton <[email protected]>
Co-authored-by: Naomi Quinones <[email protected]>
@zspencer @daltonrpruitt
@naomiquinones @anaulin
Marketplace: Buyer sees Checkout after Checkout
99c2eb4 
It does make me feel like we are using Checkout for too many things, and
maybe we want an Order class which is distinct from a Checkout but we
didn't want to jump through those hoops in this particual session.

Co-authored-by: Dalton <[email protected]>
Co-authored-by: Naomi Quinones <[email protected]>
@anaulin @zspencer
@KellyAH @daltonrpruitt
Freeze the Cart and Checkout after a successful payment, and clear ou…
e0b1f81 
…t the

current cart.

Co-authored-by: Zee <[email protected]>
Co-authored-by: Kelly <[email protected]>
Co-authored-by: Dalton <[email protected]>
@anaulin anaulin force-pushed the marketplace/begin-processing-payment branch from 8cd9268 to e0b1f81 Compare January 15, 2023 22:01
@anaulin anaulin mentioned this pull request Jan 15, 2023
Merged
@anaulin
Update CheckoutPolicy to match spec expectations (#1044)
59d312b 
This PR updates the CheckoutPolicy implementation to satisfy the expectations in the spec. I do not know if this is precisely the behavior we want -- e.g. maybe we want a "marketplace admin" (space owner?) to be able to always see a Checkout -- but we can expand the behavior later.
@anaulin anaulin mentioned this pull request Jan 16, 2023
Merged
anaulin and others added 10 commits January 15, 2023 18:46
@anaulin
Handle the "failed to initiate checkout" case and add request specs (#…
ba9db5d 
…1045)

* Handle the "failed to initiate checkout" case and add request specs.

* Add guards for the cases when we don't have a cart.
@daltonrpruitt @zspencer
Update ERD generation method and style (#1042)
00bf14b 
* Add .erdconfig file and resulting updated ERD

I don't like the connection from Membership to Space, but I'm not sure
how to fix it.

* Simplify ERD creation command

Since have new .erdconfig file, don't need to supply flags.
@dependabot @zspencer
Bump rubocop-rspec from 2.17.0 to 2.18.0 (#1046)
d756cab
@dependabot @zspencer
Bump aws-sdk-s3 from 1.117.2 to 1.118.0 (#1047)
ff1b543
@dependabot @zspencer
Bump globalid from 1.0.0 to 1.0.1 (#1049)
9649493
@zspencer
Merge branch 'main' into marketplace/begin-processing-payment
caad891
@zspencer @anaulin
@daltonrpruitt @KellyAH
Marketplace: current_cart is a lie, it's the shopper!
b5e3d67 
Co-authored-by: Ana <[email protected]>
Co-authored-by: Dalton <[email protected]>
Co-authored-by: Kelly Hong <[email protected]>
@zspencer @anaulin
@daltonrpruitt @KellyAH
Marketplace: Checking out works again!
95713af 
Co-authored-by: Ana <[email protected]>
Co-authored-by: Dalton <[email protected]>
Co-authored-by: Kelly Hong <[email protected]>
@zspencer @anaulin
@daltonrpruitt @KellyAH
Marketplace: Test that receiving a Stripe session id
0d366fb 
Co-authored-by: Ana <[email protected]>
Co-authored-by: Dalton <[email protected]>
Co-authored-by: Kelly Hong <[email protected]>
@zspencer @anaulin
@daltonrpruitt @KellyAH
Marketplace: Test relationships between Checkout and OrderedProducts
43de21c 
Co-authored-by: Ana <[email protected]>
Co-authored-by: Dalton <[email protected]>
Co-authored-by: Kelly Hong <[email protected]>
@zspencer zspencer marked this pull request as ready for review January 19, 2023 02:02
@zspencer zspencer requested review from KellyAH and anaulin and removed request for KellyAH January 19, 2023 02:02
@zspencer zspencer requested a review from sadiejay January 19, 2023 02:02
anaulin
anaulin approved these changes Jan 19, 2023
View reviewed changes
Copy link
Member

@anaulin anaulin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💸

@zspencer zspencer requested review from anaulin and a team January 19, 2023 02:02
@zspencer zspencer mentioned this pull request Jan 19, 2023
Closed
15 tasks
@zspencer zspencer merged commit e6bf54c into main Jan 19, 2023
@zspencer zspencer deleted the marketplace/begin-processing-payment branch January 19, 2023 02:28
@zspencer zspencer mentioned this pull request Apr 8, 2023
Closed
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anaulin anaulin anaulin approved these changes

@KellyAH KellyAH Awaiting requested review from KellyAH

@sadiejay sadiejay Awaiting requested review from sadiejay

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zspencer @anaulin @daltonrpruitt