Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🧹 Space, Furniture, and Room: Fill in missing associations #1285

Merged
merged 2 commits into from
Apr 2, 2023
Merged

🧹 Space, Furniture, and Room: Fill in missing associations #1285

merged 2 commits into from
Apr 2, 2023

Conversation

zspencer
Copy link
Member

As I was working to onboard Piikup, I discovered I couldn't really write an easy script to merge into a space since I didn't have the associations together.

Now they're super tight! Yyyaaaaaaah!

@zspencer
🧹 Space, Furniture, and Room: Fill in missing assocations
0a4e702 
- #832
- #1155
- #1154
- #709

As I was working to onboard Piikup, I discovered I couldn't really write
an easy script to merge into a space since I didn't have the
associations together.

Now they're super tight! Yyyaaaaaaah!
@zspencer zspencer requested review from anaulin, KellyAH, daltonrpruitt and a team March 31, 2023 19:19
anaulin
anaulin approved these changes Mar 31, 2023
View reviewed changes
Copy link
Member

@anaulin anaulin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Clears away some of the weirdnesses we had.

@anaulin anaulin changed the title 🧹 Space, Furniture, and Room: Fill in missing assocations 🧹 Space, Furniture, and Room: Fill in missing associations Apr 1, 2023
@zspencer zspencer merged commit 77a01bf into main Apr 2, 2023
@zspencer zspencer deleted the spaces/space-has-furnitures-through-rooms branch April 2, 2023 16:55
@zspencer zspencer added 🧹 refactor Includes non-behavioral changes 🥗 test automation Adds some automated tests. V nutritious. labels Apr 8, 2023
@zspencer zspencer added this to the 1.0 - Andromeda milestone May 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anaulin anaulin anaulin approved these changes

@KellyAH KellyAH Awaiting requested review from KellyAH

@daltonrpruitt daltonrpruitt Awaiting requested review from daltonrpruitt

Assignees
No one assigned
Labels
🧹 refactor Includes non-behavioral changes 🥗 test automation Adds some automated tests. V nutritious.
Projects
None yet
Milestone
1.0 - Andromeda
Development

Successfully merging this pull request may close these issues.
2 participants
@zspencer @anaulin