✨🥗🌸 Room: Improve clarity of publicity and access level options
#1301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anaulin
force-pushed
the
au/clearer-room-visibility-ui
branch
from
b3eeb76 to
5d0e196
Compare
anaulin
force-pushed
the
au/clearer-room-visibility-ui
branch
2 times, most recently
from
9543fea to
fb5c2dd
Compare
…ot Postgres enums).
anaulin
force-pushed
the
au/clearer-room-visibility-ui
branch
from
fb5c2dd to
b611f7a
Compare
zspencer
reviewed
Apr 3, 2023
| @@ -0,0 +1,9 @@ | |||
| class AddDefaultPublicity < ActiveRecord::Migration[7.0] | |||
| def up | |||
| change_column :rooms, :publicity_level, :string, default: :listed, null: false | |||
There was a problem hiding this comment.
I'm trying to decide whether :listed or :unlisted is the better default, but I am landing on 🤷
There was a problem hiding this comment.
Yeah, I wasn't sure either, but if feels like a public default sort of implies a listed default?
…groups, so that the options and choices are a little bit more visible.
anaulin
changed the title
Neighborhood: Improve clarity of Room publicity and access level options
|
Just realized that there is some weirdness in the mobile version: Not sure if that's ok to merge and iterate or not, y'all tell me. Either way, I'll look into fixing that later this week. |
zspencer
approved these changes
Apr 3, 2023
| <%= form.label attribute, option, value: option, | ||
| class: "ml-3 block text-sm leading-6 text-gray-900" %> | ||
| </div> | ||
| <%- end %> |
There was a problem hiding this comment.
Nice! I'm glad we have a radio component now!
| @@ -0,0 +1,9 @@ | |||
| class AddDefaultPublicity < ActiveRecord::Migration[7.0] | |||
| def up | |||
| change_column :rooms, :publicity_level, :string, default: :listed, null: false | |||
zspencer
changed the title
Neighborhood: Improve clarity of Room publicity and access level optionsRoom: Improve clarity of publicity and access level options
zspencer
added
🌸 Polish
zspencer
changed the title
Room: Improve clarity of publicity and access level optionsRoom: Improve clarity of publicity and access level options
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sections#1155As a follow-up on #1300, this PR replaces the visibility and access level select drop-downs in the Room edit form with radio groups.
My goal is to make the available options and current setting clearer.
I would like to soon add an "explanation text" to each of these options. I was experimenting with using Tailwind's
peer/...andpeer/...checkedclasses and I couldn't get them working reliably, so I've given up on that for now. But I'll be back.I also:
publicity_levelScreenshots
Before
After