Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌸✨ Marketplace: The Back button works! #1981

Conversation

zspencer
Copy link
Member

So, TIL about data-turbo-action=advance which tells turbo to update the URL when moving from spot to spot.

Now, when navigating through the Marketplace Management and Checkout flow the URL bar actually update! Magic! Ponies! Sparkles! Hooray!

- #831

So, TIL about `data-turbo-action=advance` which tells turbo to update
the URL when moving from spot to spot.

Now, when navigating through the Marketplace Management and Checkout
flow the URL bar actually update! Magic! Ponies! Sparkles! Hooray!
@zspencer zspencer requested review from a team November 30, 2023 02:47
Copy link
Member

@anaulin anaulin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@anaulin anaulin merged commit 1f86ba3 into main Nov 30, 2023
4 checks passed
@anaulin anaulin deleted the marketplace/back-button-works-when-navigating-through-marketplace branch November 30, 2023 03:18
@zspencer zspencer changed the title Marketplace: The Back button works! 🌸✨ Marketplace: The Back button works! Nov 30, 2023
@zspencer zspencer added ✨ feature Reduces Client's Burden or Grants them Benefits 🌸 Polish Improves the UX! labels Nov 30, 2023
zspencer added a commit that referenced this pull request Dec 3, 2023
- Follow on for #1981

I noticed this and removed the duplication but forgot to commit it!
Anyway, now it's a little tidier.
zspencer added a commit that referenced this pull request Dec 3, 2023
- Follow on for #1981

I noticed this and removed the duplication but forgot to commit it!
Anyway, now it's a little tidier.
@rosschapman
Copy link
Contributor

👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ feature Reduces Client's Burden or Grants them Benefits 🌸 Polish Improves the UX!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants