Marketplace: Destroy Products when Destroying Marketplaces #955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I keep forgetting that foreign keys need to be taken care of explicitly in relations. I'm pretty sure there's a gem that notices mismatches between dependent settings and database schemas but I don't remember what it is :X.
zspencer
requested review from
sadiejay,
anaulin,
KellyAH,
nirmalathapa and
a team
anaulin
approved these changes
Nov 27, 2022
There was a problem hiding this comment.
@dependabot squash and merge
Sorry, wrong button. I meant to say LGTM. 👍🏼
anaulin
deleted the
marketplace/destroy-products-when-destroying-a-marketplace
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: #831
I keep forgetting that foreign keys need to be taken care of explicitly
in relations. I'm pretty sure there's a gem that notices mismatches
between dependent settings and database schemas but I don't remember
what it is :X.