Marketplace: Sprout Checkout #994
Conversation
Co-authored-by: Zee Spencer <[email protected]> Co-authored-by: Ana <[email protected]>
Co-authored-by: Zee Spencer <[email protected]> Co-authored-by: Ana <[email protected]>
|
Oops I forgot to assign ya'll as reviewers after opening this PR on Wednesday. I think we wanted to get it merged ASAP right? Or are we waiting to continue it on Sunday? |
|
Well, we could merge it as is; since it seems like the tests are passing, but I would prefer to wait to merge until we showed the I don't think we need to get the actual "Create a Checkout" bit working pre-merge, but some tidying of the flow may be nice on Sunday! |
zspencer
changed the title
Co-authored-by: Zee Spencer <[email protected]> Co-authored-by: Naomi Quinones <[email protected]> Co-authored-by: CJ Joulain <[email protected]>
| @@ -24,6 +24,7 @@ def create | |||
| turbo_stream.replace("cart-product-#{cart_product.product_id}", cart_product), | |||
| turbo_stream.replace("cart-footer-#{cart.id}", | |||
| partial: "marketplace/carts/footer", locals: {cart: cart}), | |||
| turbo_stream.replace("cart-total-#{cart.id}", partial: "marketplace/carts/total", locals: {cart: cart}) | |||
There was a problem hiding this comment.
I notice we make this particular change 3 different times in this controller; what if we gathered these three replace calls into a method so they aren't duplicated everywhere? What arguments would the method need to take to work appropriately across it's different calls?
| <tfoot id="cart-footer-<%= cart.id%>" class="bg-gray-50"> | ||
| <tr> | ||
| <td></td> | ||
| <th> <%= link_to("checkout", new_space_room_marketplace_checkout_path(space, room, marketplace), html_options = {}) %> </th> |
There was a problem hiding this comment.
We may be able to use [:new, space, room, marketplace, :checkout] in place of new_space_room_marketplace_checkout_path(space, room, marketplace)
Continuing building out checkout flow in #831
TODO