Add Group::mul_by_generator
#44
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a provided method to the `Group` trait for performing multiplication by the generator. The use case is overriding this method in the event that precomputed scalar multiplication tables are available, which may be conditional depending on crate features like `alloc` or feature-gated static precomputed tables.
This was referenced Dec 30, 2022
str4d
approved these changes
Jul 29, 2023
There was a problem hiding this comment.
ACK, thanks!
This is adding a provided method to a trait, which is a possibly-breaking change. Per existing precedent for these crates, I consider it a minor change, so we can push this out with a point release. I will hold off merging this PR however until the other bugfix PRs are ready so I can determine what the content of the next release will be.
|
Re-linking #45 here because I'd forgotten about that issue, and it is relevant to whether we merge this PR. |
|
The use case described in #45 was a generator stored as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a provided method to the
Grouptrait for performing multiplication by the generator.The use case is overriding this method in the event that precomputed scalar multiplication tables are available, which may be conditional depending on crate features like
allocor feature-gated static precomputed tables.