Fixed solo CSS having typographie rules from Foundation #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This caused issues with other CSS rules. Addresses zurb#226
kball
reviewed
May 22, 2017
| @@ -25,7 +25,6 @@ | |||
|
|
|||
|
|
|||
| // Imports | |||
| @include foundation-typography; | |||
| @include foundation-visibility-classes; | |||
|
|
|||
| {{#components}} | |||
There was a problem hiding this comment.
Had the thought looking at this... why are we including so many components? Almost certainly we only need a few...
There was a problem hiding this comment.
The components are automatically rendered into the SASS file using the configuration file https://github.com/zurb/joyride/blob/master/gulp/config.js. Only Reveal and Tooltip are used here, plus some utility stuff.
|
I'd go ahead and wrap up a 3.0.1 with this fix then... Seems reasonable enough for me to update for this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This caused issues with other CSS rules.
Addresses #226
Ping @kball, please check this out.