Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[API WRAPPER] Fixes #403 implementing API wrapper to update reminders #477

Closed
wants to merge 1 commit into from
Closed

[API WRAPPER] Fixes #403 implementing API wrapper to update reminders #477

wants to merge 1 commit into from

Conversation

godswilludoh
Copy link
Contributor

Fixes #403 implementing API wrapper to update reminders

a11rew
a11rew suggested changes Sep 13, 2021
View reviewed changes
Copy link
Contributor

@a11rew a11rew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You shouldn't be providing placeholder data in a mutation query, Destructure the response body and return only the response, not data.data to get the response body. You also have to handle errors

@a11rew a11rew deleted the branch zurichat:design-update September 14, 2021 22:19
@a11rew a11rew closed this Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a11rew a11rew a11rew requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@godswilludoh @a11rew @officialgodswil