Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Dockerfile and Makefile #871

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

coin-au-carre
Copy link

In order for make build-image && make run-web-server to work I had to modify:

Dockerfile

The Docker's ENTRYPOINT is set to ["python"] but it's trying to run the Python module with all the command line arguments. When you run the container, it just tries to execute Python with those arguments rather than running your manga translator module.

Makefile

Locally I want to use the local image name if I use zyddnys/manga-image-translator this will pull the one remotely.

@coin-au-carre
Copy link
Author

If you don't want to change the Dockerfile we can change the Makefile only with something like this:

run-web-server:
	docker run --gpus all -p 5003:5003 --ipc=host --rm zyddnys/manga-image-translator:main \
		-m manga_translator \
		--target-lang=ENG \
		--manga2eng \
		--verbose \
		--mode web \
		--use-gpu \
		--host=0.0.0.0 \
		--port=5003

@frederik-uni
Copy link
Contributor

@coin-au-carre the entrypoint can't be ENTRYPOINT ["python", "-m", "manga_translator" because the server isn't part of the manga_translator module

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants