Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pii around upn for wp registration web response #1444

Open
wants to merge 6 commits into
base: release/1.7.43
Choose a base branch
from

Conversation

kaisong1990
Copy link
Contributor

Proposed changes

Add PII around upn

Type of change

  • Feature work
  • Bug fix
  • Documentation
  • Engineering change
  • Test
  • Logging/Telemetry

Risk

  • High – Errors could cause MAJOR regression of many scenarios. (Example: new large features or high level infrastructure changes)
  • Medium – Errors could cause regression of 1 or more scenarios. (Example: somewhat complex bug fixes, small new features)
  • Small – No issues are expected. (Example: Very small bug fixes, string changes, or configuration settings changes)

Additional information

@kaisong1990 kaisong1990 requested a review from a team as a code owner November 15, 2024 00:59
@@ -122,7 +122,7 @@ - (void)handleWebMSAuthResponse:(MSIDWebWPJResponse *)response completion:(MSIDR
MSID_LOG_WITH_CTX(MSIDLogLevelInfo, self.requestParameters, @"Workplace join Upgrade registration is required.");

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not update changelog.txt.

Please consider if this change would be noticeable to a partner or user and either update changelog.txt or resolve this conversation.

Copy link
Member

@oldalton oldalton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't use _PII_NULLIFY for actual code, since we rely on user info as part of the flow. We should only do _PII_NULLIFY in logs

@kaisong1990 kaisong1990 requested a review from oldalton November 15, 2024 06:12
@kaisong1990
Copy link
Contributor Author

Hi @oldalton do we need to check into this release or if we can wait till the next one?

@kaisong1990
Copy link
Contributor Author

kaisong1990 commented Nov 22, 2024

We shouldn't use _PII_NULLIFY for actual code, since we rely on user info as part of the flow. We should only do _PII_NULLIFY in logs

Hi @oldalton I benchmarked the performance, and the difference is below 1 ms. The NSRange solution is slightly better, and it is currently used in MSIDMaskedUsernameLogParameter so I switched with the similar logic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants