-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pii around upn for wp registration web response #1444
base: release/1.7.43
Are you sure you want to change the base?
Conversation
@@ -122,7 +122,7 @@ - (void)handleWebMSAuthResponse:(MSIDWebWPJResponse *)response completion:(MSIDR | |||
MSID_LOG_WITH_CTX(MSIDLogLevelInfo, self.requestParameters, @"Workplace join Upgrade registration is required."); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pull request does not update changelog.txt.
Please consider if this change would be noticeable to a partner or user and either update changelog.txt or resolve this conversation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We shouldn't use _PII_NULLIFY for actual code, since we rely on user info as part of the flow. We should only do _PII_NULLIFY in logs
Hi @oldalton do we need to check into this release or if we can wait till the next one? |
Hi @oldalton I benchmarked the performance, and the difference is below 1 ms. The NSRange solution is slightly better, and it is currently used in |
Proposed changes
Add PII around upn
Type of change
Risk
Additional information