Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pii around upn for wp registration web response #1444

Open
wants to merge 6 commits into
base: release/1.7.43
Choose a base branch
from
Open

Add pii around upn for wp registration web response #1444

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5936a58
Add pii around upn
Nov 15, 2024
3159581
hide userinfo for error logging
Nov 15, 2024
461309f
Apply mask on email address from user info MSALDisplayableUserIdKey
Nov 15, 2024
558ba69
formatting
Nov 15, 2024
62bc447
formatting
Nov 15, 2024
5d3f187
switch to use NSrange
Nov 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions IdentityCore/src/controllers/MSIDLocalInteractiveController.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ - (void)handleWebMSAuthResponse:(MSIDWebWPJResponse *)response completion:(MSIDR
MSID_LOG_WITH_CTX(MSIDLogLevelInfo, self.requestParameters, @"Workplace join Upgrade registration is required.");
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not update changelog.txt.

Please consider if this change would be noticeable to a partner or user and either update changelog.txt or resolve this conversation.


NSMutableDictionary *additionalInfo = [NSMutableDictionary new];
additionalInfo[MSIDUserDisplayableIdkey] = response.upn;
additionalInfo[MSIDUserDisplayableIdkey] = _PII_NULLIFY(response.upn);
additionalInfo[MSIDHomeAccountIdkey] = response.clientInfo.accountIdentifier;

registrationError = MSIDCreateError(MSIDErrorDomain, MSIDErrorInsufficientDeviceStrength,
Expand All @@ -133,7 +133,7 @@ - (void)handleWebMSAuthResponse:(MSIDWebWPJResponse *)response completion:(MSIDR
MSID_LOG_WITH_CTX(MSIDLogLevelInfo, self.requestParameters, @"Workplace join is required.");

NSMutableDictionary *additionalInfo = [NSMutableDictionary new];
additionalInfo[MSIDUserDisplayableIdkey] = response.upn;
additionalInfo[MSIDUserDisplayableIdkey] = _PII_NULLIFY(response.upn);
additionalInfo[MSIDHomeAccountIdkey] = response.clientInfo.accountIdentifier;
additionalInfo[MSIDTokenProtectionRequired] = response.tokenProtectionRequired ? @(YES) : @(NO);

Expand Down
Loading