Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Missing Claims Propagation in SignedAssertionWithAssertionRequestOptions Delegate #5143

Closed
gladjohn opened this issue Feb 13, 2025 · 0 comments · Fixed by #5145
Closed

Comments

@gladjohn
Copy link
Contributor

Library version used

Latest

.NET version

net 8

Scenario

ConfidentialClient - service to service (AcquireTokenForClient)

Is this a new or an existing app?

This is a new app or experiment

Issue description and reproduction steps

When using the delegate-based flow (.WithClientAssertion(options => ...)) in MSAL to generate a client assertion, the Claims property from AssertionRequestOptions is not being propagated into the final assertion. Although Claims is already part of AssertionRequestOptions, it is currently not consumed or forwarded in code paths that rely on the delegate.

Relevant code snippets

Expected behavior

Claims provided in AssertionRequestOptions.Claims should be included in the client assertion that is sent to the token endpoint.

Identity provider

Microsoft Entra ID (Work and School accounts and Personal Microsoft accounts)

Regression

No response

Solution and workarounds

When building the AssertionRequestOptions, ensure that the Claims property is passed to the delegate and included in the final assertion.

@gladjohn gladjohn added needs attention Delete label after triage untriaged Do not delete. Needed for Automation labels Feb 13, 2025
@gladjohn gladjohn self-assigned this Feb 13, 2025
@gladjohn gladjohn added confidential-client bug P2 and removed untriaged Do not delete. Needed for Automation needs attention Delete label after triage labels Feb 13, 2025
@gladjohn gladjohn moved this from Committed to Committed High Priority in MSAL Customer Trust / QM Feb 13, 2025
@gladjohn gladjohn added this to the 4.68.1 milestone Feb 13, 2025
@github-project-automation github-project-automation bot moved this from Committed High Priority to Done in MSAL Customer Trust / QM Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment