Add UV mirrors settings #2333
Add UV mirrors settings #2333
Conversation
huchenlei
force-pushed
the
mirror_settings
branch
from
ffb1fd4 to
d68f6a7
Compare
|
Updated dependencies detected. Learn more about Socket for GitHub ↗︎
|
huchenlei
requested review from
Yorha4D,
KarryCharon,
DorotaLuna,
shinshin86 and
a team
as code owners
There was a problem hiding this comment.
Current mechanism looks good. Additional thoughts:
-
On the "bad connection" page, should we first add a banner warning that says "Bad access to python mirror. The download might fail", similar to the bottom banners on the "good" or "loading" pages?
-
On this “bad connection” page， users might first try to switch their network before setting mirrors. Do we have a refresh mechanism that enables the page to re-evaluate？ (I'm sorry I can't directly check from the code)
|
Looks good! Will we provide a default mirror for python source? |
| const checkPypiMirrorReachable = async (mirror: string) => { | ||
| return ( | ||
| isValidUrl(mirror) && | ||
| (await electronAPI().NetWork.canAccessUrl( |
There was a problem hiding this comment.
I believe this is for pypy which is different from pypi.
https://docs.astral.sh/uv/configuration/environment/#uv_pypy_install_mirror
There was a problem hiding this comment.
There was a problem hiding this comment.
Yes we need to fix this. We probably also want to verify connection to torch mirror.
See |
Fixed in #2339. User can refresh by clicking the status icon, i.e. the red cross. |
huchenlei
force-pushed
the
mirror_settings
branch
from
7759c99 to
5616a0a
Compare
|
I updated the design to be a collapsable panel. The panel is collapsed by default and shows the overall status of the mirror connections. Good connection
Bad connection
Loading
Collapsed
|
Requires:
This PR adds python/pypi mirrors configuration to the install wizard. Users will be prompted to configure mirrors if they don't have access to the default python mirrors.
Good connection
Bad connection
Loading state
┆Issue is synchronized with this Notion page by Unito