Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add UV mirror settings #713

Merged
merged 1 commit into from
Jan 24, 2025
Merged

Add UV mirror settings #713

merged 1 commit into from
Jan 24, 2025

Conversation

huchenlei
Copy link
Member

@huchenlei huchenlei commented Jan 24, 2025 •
edited by sync-by-unito bot
Loading

  1. Added new settings for Python and PyPI mirrors:

    • Added PythonInstallMirror and PypiInstallMirror to DEFAULT_SETTINGS and ComfySettingsData interface
    • These settings allow configuring alternative mirrors for Python and PyPI package installations

  2. Refactored ComfyDesktopApp and ComfyInstallation:

    • Moved ComfySettings management from ComfyDesktopApp to ComfyInstallation
    • Changed ComfySettings to be a property in ComfyDesktopApp

  3. Enhanced VirtualEnvironment:

    • Refactored constructor to accept an options object instead of individual parameters
    • Added support for Python and PyPI mirrors through environment variables
    • Updated default Python version handling

  4. Updated InstallWizard to include mirror settings in the installation options

┆Issue is synchronized with this Notion page by Unito

@huchenlei huchenlei requested review from a team as code owners January 24, 2025 01:34
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Jan 24, 2025
@huchenlei huchenlei mentioned this pull request Jan 24, 2025
Merged
@dosubot dosubot bot added the enhancement New feature or request label Jan 24, 2025
@huchenlei huchenlei merged commit a6a59f6 into main Jan 24, 2025
6 checks passed
@huchenlei huchenlei deleted the mirror_settings branch January 24, 2025 03:12
christian-byrne
christian-byrne reviewed Jan 24, 2025
View reviewed changes
src/main-process/comfyInstallation.ts
@@ -41,7 +43,7 @@ export class ComfyInstallation {
set basePath(value: string) {
// Duplicated in constructor to avoid non-nullable type assertions.
this._basePath = value;
this.virtualEnvironment = new VirtualEnvironment(value, this.telemetry, this.device);
this.virtualEnvironment = this.createVirtualEnvironment(value);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the future we should remove side effect from setter, as it is very difficult to maintain.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Filed: #715

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christian-byrne christian-byrne christian-byrne left review comments

Assignees
No one assigned
Labels
enhancement New feature or request size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@huchenlei @christian-byrne