Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chart editor - Open hold note context menu if note is hold note #4231

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Lasercar
Copy link
Contributor

Does this PR close any issues? If so, link them below.

No, but it prevents one from being opened in the future!

Briefly describe the issue(s) fixed.

Opening the context menu on the note of a hold note would open the regular note context menu, rather than the hold note one.

This change pairs very well with my improved context menus.

Include any relevant screenshots or videos.

Before:

2025-02-26.19-09-27.mp4

After:

2025-02-26.19-10-56.mp4

@github-actions github-actions bot added size: small A small pull request with 10 or fewer changes. pr: haxe PR modifies game code. status: pending triage Awaiting review. and removed size: small A small pull request with 10 or fewer changes. labels Feb 26, 2025
@Hundrec Hundrec added size: small A small pull request with 10 or fewer changes. topic: chart editor Related to the operation of the Chart Editor. labels Feb 26, 2025
@AbnormalPoof AbnormalPoof added the type: minor bug Involves a minor bug or issue. label Feb 26, 2025
Copy link
Collaborator

@Hundrec Hundrec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great in my testing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: haxe PR modifies game code. size: small A small pull request with 10 or fewer changes. status: pending triage Awaiting review. topic: chart editor Related to the operation of the Chart Editor. type: minor bug Involves a minor bug or issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants