-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Proxy colonies M1] feat: create proxy colony via voting reputation #4036
base: feat/re-enable-proxy-colony
Are you sure you want to change the base?
[Proxy colonies M1] feat: create proxy colony via voting reputation #4036
Conversation
81ae988
to
6295a4f
Compare
d8e2b62
to
8c0aa8c
Compare
6295a4f
to
7e6f635
Compare
8c0aa8c
to
055fdfc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, good stuff @bassgeta. Obviously I saw most of this done live while on the call, but I went over it again and gave it some testing locally. All working well! Aside from the one comment which you already know about (completed not being set to true in the motion action).
Checking the block ingestor PR now. On this side though all good 🚀
@@ -1,8 +1,7 @@ | |||
FROM colony-cdapp-dev-env/base:latest | |||
|
|||
# @TODO maybe add a PROXY_BLOCK_INGESTOR_HASH and fallback to BLOCK_INGESTOR_HASH | |||
ENV BLOCK_INGESTOR_HASH=3e66c1f5d0245048930f0aeae55fa332de6989f4 | |||
|
|||
ENV BLOCK_INGESTOR_HASH=68a509568e06f233511e468959a0ab8afe87bfc2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be nice to streamline this somehow so we only have to update it in one place. I'm sure you and Ioanna already thought about this though, and it's a super future improvement anyway, just throwing it out there!
Description
This PR adds functionality to create a proxy colony via voting reputation.
Additionally it adds tracing between actions which are motion finalization and the motion they have finalized.
So basically
finalizationActionId
is a new attribute set on voting reputation and multisig motions, which tells us which txHash finalized this motion.finalizedActionId
is a new field on the action object which tells us which txHash was finalized by this action.So we have this bound in two ways just in case we want to search it from both ends.
Block ingestor PR
Testing
First of all, start up your dev env, run the create data script and install the voting reputation extension.
Before we try out the proxy colony part lets check out if motions are in fact linked to their finalization actions.
4. Since we see that
finalizedActionData
is populated and has the isMotionFinalization set totrue
it means we have succesfully saved this. But let's try doing it the other way around. Run the following queryVerify that the action's
finalizedActionId
equals to the parent motion's txHash and that its flagisMotionFinalization
is se to true. AdditionallyfinalizedActionData
should be of typeMINT_TOKENS_MOTION
.Manage supported chains
action and chooseReputation
as the decision method7. Run the following query and verify that the motion has the target chain, but no action that finalized it (Note that currently
multiChainInfo
is used here just to get the chain we are deploying to)8. Fully support the motion and Finalize it (
npm run forward-time 1
or just oppose it and get to the voting step)9. Finalize it and verify that
a) the proxy colony was deployed by running the
listProxyColonies
query from aboveb) the motion now has a
finalizedActionId
and the action multichain info is filled inYou can also check that the chain doesn't appear in the
Add supported chain
dropdown!Diffs
New stuff ✨
createProxyColonyMotion
sagaADD_PROXY_COLONY_MOTION
Changes 🏗
finalizationActionId
to both multisig and voting reputation motions (check out the block-ingestor)Resolves #3450