-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support multi-column filtering for DF2TFilter
#602
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #602 +/- ##
==========================================
+ Coverage 97.90% 97.91% +0.01%
==========================================
Files 19 19
Lines 3246 3262 +16
==========================================
+ Hits 3178 3194 +16
Misses 68 68 ☔ View full report in Codecov by Sentry. |
does not have performance repercussions for Vector and Matrix states
83c9df4
to
5bfcfb0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, apart from documentation and some formatting.
Co-authored-by: wheeheee <[email protected]>
3f59f11
to
b25e962
Compare
How do you like the rewritten docstring? |
The explanation about what |
Yes, worth considering. (For docstrings being edited anyway; I wouldn't want to go through the whole code base and change this.) This could become
or without using default args
The latter seems excessive, although I like that the one-argument case is more explicit, as it will probably by the one most often used. So maybe
? |
b25e962
to
307428a
Compare
Looks good! |
Ok, will merge once CI is green. |
Fixes #372. I mostly wanted to see whether #372 could be tackled in a non-breaking way. The answer is yes, so this could wait until after release of v0.8. OTOH, it seems simple enough that it's unlikely to stall v0.8 even more, so here it is.
Note that while this is API-wise orthogonal to #599, there will be some clean-up possible after both of them have been merged. (Or rather, after the first one merges, the second one can be extended to include the clean-up.)