KCL: (x/y)Line(To) is now kwargs #5486
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5486 +/- ##
==========================================
+ Coverage 86.26% 86.28% +0.02%
==========================================
Files 95 95
Lines 35901 35925 +24
==========================================
+ Hits 30970 30998 +28
+ Misses 4931 4927 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
adamchalmers
force-pushed
the
achalmers/xline-kw
branch
from
f3284bf to
8a140f4
Compare
adamchalmers
force-pushed
the
achalmers/xline-kw
branch
from
8a140f4 to
6207270
Compare
adamchalmers
force-pushed
the
achalmers/xline-kw
branch
from
3698be4 to
7a9fc62
Compare
|
|
adamchalmers
changed the title
adamchalmers
force-pushed
the
achalmers/xline-kw
branch
from
7a9fc62 to
b509c86
Compare
adamchalmers
force-pushed
the
achalmers/xline-kw
branch
from
299021b to
32dcda3
Compare
Cases where the application/library code was correct, but the test code was wrong.
…t to a tooltip if so
Combination of two issues: - Test was wrong - Library code for removing constraints from sketch lines was wrong, was not properly recognizing when kw calls were absolute or relative because they only considered the function name, not its parameters (and parameters like 'length' or 'endAbsolute' determine if a call is actually relative/absolute, not just the function name)
adamchalmers
force-pushed
the
achalmers/xline-kw
branch
from
8225bad to
3e08a4f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.